dhcp_protocol/

lib.rs

// Copyright 2018 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

use bstr::BString;
use log::debug;
use net_types::ethernet::Mac as MacAddr;
use net_types::ip::{Ipv4, NotSubnetMaskError, PrefixLength};
use num_derive::FromPrimitive;
use serde::{Deserialize, Serialize};
use std::fmt;
use std::net::Ipv4Addr;
use std::num::{NonZeroU8, NonZeroU16};
use thiserror::Error;

#[cfg(target_os = "fuchsia")]
use std::convert::Infallible as Never;

mod size_constrained;
pub use crate::size_constrained::{
    AtLeast, AtMostBytes, Error as SizeConstrainedError, U8_MAX_AS_USIZE,
};

mod size_of_contents;
use crate::size_of_contents::SizeOfContents as _;

/// The port on which DHCP servers receive messages from DHCP clients.
///
/// Per [RFC 2131 section 4.1], "DHCP messages from a client to a server are
/// sent to the 'DHCP server' port (67)".
///
/// [RFC 2131 section 4.1]: https://datatracker.ietf.org/doc/html/rfc2131#section-4.1
pub const SERVER_PORT: NonZeroU16 = NonZeroU16::new(67).unwrap();

/// The port on which DHCP clients receive messages from DHCP servers.
///
/// Per [RFC 2131 section 4.1], "DHCP messages from a server to a client are
/// sent to the 'DHCP client' port (68)".
///
/// [RFC 2131 section 4.1]: https://datatracker.ietf.org/doc/html/rfc2131#section-4.1
pub const CLIENT_PORT: NonZeroU16 = NonZeroU16::new(68).unwrap();

const OP_IDX: usize = 0;
// currently unused
//const HTYPE_IDX: usize = 1;
//const HLEN_IDX: usize = 2;
//const HOPS_IDX: usize = 3;
const XID_IDX: usize = 4;
const SECS_IDX: usize = 8;
const FLAGS_IDX: usize = 10;
const CIADDR_IDX: usize = 12;
const YIADDR_IDX: usize = 16;
const SIADDR_IDX: usize = 20;
const GIADDR_IDX: usize = 24;
const CHADDR_IDX: usize = 28;
const SNAME_IDX: usize = 44;
const FILE_IDX: usize = 108;
const OPTIONS_START_IDX: usize = 236;

const ETHERNET_HTYPE: u8 = 1;
const ETHERNET_HLEN: u8 = 6;
const HOPS_DEFAULT: u8 = 0;
const MAGIC_COOKIE: [u8; 4] = [99, 130, 83, 99];

const UNUSED_CHADDR_BYTES: usize = 10;

const CHADDR_LEN: usize = 6;
const SNAME_LEN: usize = 64;
const FILE_LEN: usize = 128;
const IPV4_ADDR_LEN: usize = 4;

// Datagrams and DHCP Messages must both be at least 576 bytes.
// - Datagram: https://datatracker.ietf.org/doc/html/rfc2132#section-4.4
// - DHCP Message: https://datatracker.ietf.org/doc/html/rfc2132#section-9.10
const MIN_MESSAGE_SIZE: u16 = 576;

// Minimum legal value for mtu is 68.
// https://datatracker.ietf.org/doc/html/rfc2132#section-5.1
const MIN_MTU_VAL: u16 = 68;

const ASCII_NULL: char = '\x00';

#[derive(Debug, Error, PartialEq)]
pub enum ProtocolError {
    #[error("invalid buffer length: {}", _0)]
    InvalidBufferLength(usize),

    #[cfg(target_os = "fuchsia")]
    #[error("option not supported in fuchsia.net.dhcp: {:?}", _0)]
    InvalidFidlOption(DhcpOption),
    #[error("invalid message type: {}", _0)]
    InvalidMessageType(u8),
    #[error("invalid bootp op code: {}", _0)]
    InvalidOpCode(u8),
    #[error("invalid option code: {}", _0)]
    InvalidOptionCode(u8),
    #[error("invalid option value. code: {}, value: {:?}", _0, _1)]
    InvalidOptionValue(OptionCode, Vec<u8>),
    #[error("missing opcode")]
    MissingOpCode,
    #[error("missing expected option: {}", _0)]
    MissingOption(OptionCode),
    #[error(
        "malformed option {code} needs at least {want} bytes, but buffer has {remaining} remaining"
    )]
    MalformedOption { code: u8, remaining: usize, want: usize },

    #[cfg(target_os = "fuchsia")]
    #[error("received unknown fidl option variant")]
    UnknownFidlOption,
    #[error("invalid utf-8 after buffer index: {}", _0)]
    Utf8(usize),
    #[error("invalid protocol field {} = {} for message type {}", field, value, msg_type)]
    InvalidField { field: String, value: String, msg_type: MessageType },
}

#[derive(Debug, Error, PartialEq)]
#[error("Buffer is of invalid length: {0}")]
struct InvalidBufferLengthError(usize);

impl From<InvalidBufferLengthError> for ProtocolError {
    fn from(err: InvalidBufferLengthError) -> ProtocolError {
        let InvalidBufferLengthError(len) = err;
        ProtocolError::InvalidBufferLength(len)
    }
}

impl From<InvalidBufferLengthError> for BooleanConversionError {
    fn from(err: InvalidBufferLengthError) -> BooleanConversionError {
        let InvalidBufferLengthError(len) = err;
        BooleanConversionError::InvalidBufferLength(len)
    }
}

/// A DHCP protocol message as defined in RFC 2131.
///
/// All fields in `Message` follow the naming conventions outlined in the RFC.
/// Note that `Message` does not expose `htype`, `hlen`, or `hops` fields, as
/// these fields are effectively constants.
#[derive(Debug, PartialEq)]
pub struct Message {
    pub op: OpCode,
    pub xid: u32,
    pub secs: u16,
    pub bdcast_flag: bool,
    /// `ciaddr` should be stored in Big-Endian order, e.g `[192, 168, 1, 1]`.
    pub ciaddr: Ipv4Addr,
    /// `yiaddr` should be stored in Big-Endian order, e.g `[192, 168, 1, 1]`.
    pub yiaddr: Ipv4Addr,
    /// `siaddr` should be stored in Big-Endian order, e.g `[192, 168, 1, 1]`.
    pub siaddr: Ipv4Addr,
    /// `giaddr` should be stored in Big-Endian order, e.g `[192, 168, 1, 1]`.
    pub giaddr: Ipv4Addr,
    /// `chaddr` should be stored in Big-Endian order,
    /// e.g `[0xAA, 0xBB, 0xCC, 0xDD, 0xEE, 0xFF]`.
    pub chaddr: MacAddr,
    /// `sname` should not exceed 64 characters.
    pub sname: BString,
    /// `file` should not exceed 128 characters.
    pub file: BString,
    pub options: Vec<DhcpOption>,
}

impl Message {
    /// Instantiates a new `Message` from a byte buffer conforming to the DHCP
    /// protocol as defined RFC 2131. Returns `None` if the buffer is malformed.
    /// Any malformed configuration options will be skipped over, leaving only
    /// well formed `DhcpOption`s in the final `Message`.
    pub fn from_buffer(buf: &[u8]) -> Result<Self, ProtocolError> {
        let options =
            buf.get(OPTIONS_START_IDX..).ok_or(ProtocolError::InvalidBufferLength(buf.len()))?;
        let options = {
            let magic_cookie = options
                .get(..MAGIC_COOKIE.len())
                .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?;
            let options = options
                .get(MAGIC_COOKIE.len()..)
                .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?;
            if magic_cookie == MAGIC_COOKIE {
                parse_options(options, Vec::new())?
            } else {
                Vec::new()
            }
        };

        // Ordinarily, DHCP Options are stored in the variable length option field.
        // However, a client can, at its discretion, store Options in the typically unused
        // sname and file fields. If it wants to do this, it puts an OptionOverload option
        // in the options field to indicate that additional options are either in the sname
        // field, or the file field, or both. Consequently, we must:
        //
        // 1. Parse the options field.
        // 2. Check if the parsed options include an OptionOverload.
        // 3. If it does, grab the bytes from the field(s) indicated by the OptionOverload
        //    option.
        // 4. Parse those bytes into options.
        // 5. Combine those parsed options with whatever was in the variable length
        //    option field.
        //
        // From RFC 2131 pp23-24:
        //
        //     If the options in a DHCP message extend into the 'sname' and 'file'
        //     fields, the 'option overload' option MUST appear in the 'options' field,
        //     with value 1, 2 or 3, as specified in RFC 1533.
        //
        //     The options in the 'options' field MUST be interpreted first, so
        //     that any 'option overload' options may be interpreted.
        let overload = options.iter().find_map(|v| match v {
            &DhcpOption::OptionOverload(overload) => Some(overload),
            _ => None,
        });
        let sname =
            buf.get(SNAME_IDX..FILE_IDX).ok_or(ProtocolError::InvalidBufferLength(buf.len()))?;
        let file = buf
            .get(FILE_IDX..OPTIONS_START_IDX)
            .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?;
        let options = match overload {
            Some(overload) => {
                let extra_opts = match overload {
                    Overload::SName => sname,
                    Overload::File => file,
                    Overload::Both => buf
                        .get(SNAME_IDX..OPTIONS_START_IDX)
                        .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?,
                };
                parse_options(extra_opts, options)?
            }
            None => options,
        };
        Ok(Self {
            op: OpCode::try_from(*buf.get(OP_IDX).ok_or(ProtocolError::MissingOpCode)?)?,
            xid: u32::from_be_bytes(
                <[u8; 4]>::try_from(
                    buf.get(XID_IDX..SECS_IDX)
                        .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?,
                )
                .map_err(|std::array::TryFromSliceError { .. }| {
                    ProtocolError::InvalidBufferLength(buf.len())
                })?,
            ),
            secs: u16::from_be_bytes(
                <[u8; 2]>::try_from(
                    buf.get(SECS_IDX..FLAGS_IDX)
                        .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?,
                )
                .map_err(|std::array::TryFromSliceError { .. }| {
                    ProtocolError::InvalidBufferLength(buf.len())
                })?,
            ),
            bdcast_flag: *buf
                .get(FLAGS_IDX)
                .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?
                != 0,
            ciaddr: ip_addr_from_buf_at(buf, CIADDR_IDX)?,
            yiaddr: ip_addr_from_buf_at(buf, YIADDR_IDX)?,
            siaddr: ip_addr_from_buf_at(buf, SIADDR_IDX)?,
            giaddr: ip_addr_from_buf_at(buf, GIADDR_IDX)?,
            chaddr: MacAddr::new(
                buf.get(CHADDR_IDX..CHADDR_IDX + CHADDR_LEN)
                    .ok_or(ProtocolError::InvalidBufferLength(buf.len()))?
                    .try_into()
                    .map_err(|std::array::TryFromSliceError { .. }| {
                        ProtocolError::InvalidBufferLength(buf.len())
                    })?,
            ),
            sname: match overload {
                Some(Overload::SName) | Some(Overload::Both) => BString::default(),
                Some(Overload::File) | None => buf_to_msg_string(sname),
            },
            file: match overload {
                Some(Overload::File) | Some(Overload::Both) => BString::default(),
                Some(Overload::SName) | None => buf_to_msg_string(file),
            },
            options,
        })
    }

    /// Consumes the calling `Message` to serialize it into a buffer of bytes.
    pub fn serialize(self) -> Vec<u8> {
        let Self {
            op,
            xid,
            secs,
            bdcast_flag,
            ciaddr,
            yiaddr,
            siaddr,
            giaddr,
            chaddr,
            sname,
            file,
            options,
        } = self;
        let mut buffer = Vec::with_capacity(OPTIONS_START_IDX);
        buffer.push(op.into());
        buffer.push(ETHERNET_HTYPE);
        buffer.push(ETHERNET_HLEN);
        buffer.push(HOPS_DEFAULT);
        buffer.extend_from_slice(&xid.to_be_bytes());
        buffer.extend_from_slice(&secs.to_be_bytes());
        if bdcast_flag {
            // Set most significant bit.
            buffer.push(128u8);
        } else {
            buffer.push(0u8);
        }
        buffer.push(0u8);
        buffer.extend_from_slice(&ciaddr.octets());
        buffer.extend_from_slice(&yiaddr.octets());
        buffer.extend_from_slice(&siaddr.octets());
        buffer.extend_from_slice(&giaddr.octets());
        buffer.extend_from_slice(&chaddr.bytes().as_ref());
        buffer.extend_from_slice(&[0u8; UNUSED_CHADDR_BYTES]);
        trunc_string_to_n_and_push(&sname, SNAME_LEN, &mut buffer);
        trunc_string_to_n_and_push(&file, FILE_LEN, &mut buffer);

        buffer.extend_from_slice(&MAGIC_COOKIE);
        for option in options.into_iter() {
            option.serialize_to(&mut buffer);
        }
        buffer.push(OptionCode::End.into());

        buffer
    }

    /// Returns the value's DHCP `MessageType` or appropriate `MessageTypeError` in case of failure.
    pub fn get_dhcp_type(&self) -> Result<MessageType, ProtocolError> {
        self.options
            .iter()
            .filter_map(|opt| match opt {
                DhcpOption::DhcpMessageType(v) => Some(*v),
                _ => None,
            })
            .next()
            .ok_or(ProtocolError::MissingOption(OptionCode::DhcpMessageType))
    }
}

pub mod identifier {
    use super::{CHADDR_LEN, DhcpOption, Message};
    use net_types::ethernet::Mac as MacAddr;
    use std::convert::TryInto as _;

    const CLIENT_IDENTIFIER_ID: &'static str = "id";
    const CLIENT_IDENTIFIER_CHADDR: &'static str = "chaddr";

    /// An opaque identifier which uniquely identifies a DHCP client to a DHCP server.
    #[derive(Clone, Debug, Eq, Hash, PartialEq)]
    pub struct ClientIdentifier {
        inner: ClientIdentifierInner,
    }

    #[derive(Clone, Debug, Eq, Hash, PartialEq)]
    enum ClientIdentifierInner {
        /// An identifier derived from a Client-identifier DHCP Option, as defined in
        /// https://tools.ietf.org/html/rfc2132#section-9.14.
        Id(Vec<u8>),
        /// An identifier derived from the chaddr field of a DHCP message, typically only used in the
        /// absense of the Client-identifier DHCP Option.
        Chaddr(MacAddr),
    }

    impl From<MacAddr> for ClientIdentifier {
        fn from(v: MacAddr) -> Self {
            Self { inner: ClientIdentifierInner::Chaddr(v) }
        }
    }

    impl From<&Message> for ClientIdentifier {
        /// Returns the opaque client identifier associated with the argument message.
        ///
        /// Typically, a message will contain a `DhcpOption::ClientIdentifier` which stores the
        /// associated opaque client identifier. In the absence of this option, an identifier
        /// will be constructed from the `chaddr` field of the message.
        fn from(msg: &Message) -> ClientIdentifier {
            msg.options
                .iter()
                .find_map(|opt| match opt {
                    DhcpOption::ClientIdentifier(v) => Some(ClientIdentifier {
                        inner: ClientIdentifierInner::Id(v.clone().into()),
                    }),
                    _ => None,
                })
                .unwrap_or_else(|| ClientIdentifier::from(msg.chaddr))
        }
    }

    impl std::str::FromStr for ClientIdentifier {
        type Err = anyhow::Error;

        fn from_str(s: &str) -> Result<Self, Self::Err> {
            let mut id_parts = s.splitn(2, ":");
            let id_type = id_parts
                .next()
                .ok_or_else(|| anyhow::anyhow!("no client id type found in string: {}", s))?;
            let id = id_parts
                .next()
                .ok_or_else(|| anyhow::anyhow!("no client id found in string: {}", s))?;
            match id_parts.next() {
                None => (),
                Some(v) => {
                    return Err(anyhow::anyhow!(
                        "client id string contained unexpected fields: {}",
                        v
                    ));
                }
            };
            let id = hex::decode(id)?;
            match id_type {
                CLIENT_IDENTIFIER_ID => Ok(Self { inner: ClientIdentifierInner::Id(id) }),
                CLIENT_IDENTIFIER_CHADDR => Ok(Self {
                    inner: ClientIdentifierInner::Chaddr(MacAddr::new(
                        id.get(..CHADDR_LEN)
                            .ok_or_else(|| {
                                anyhow::anyhow!("client id had insufficient length: {:?}", id)
                            })?
                            .try_into()?,
                    )),
                }),
                id_type => Err(anyhow::anyhow!("unrecognized client id type: {}", id_type)),
            }
        }
    }

    impl std::fmt::Display for ClientIdentifier {
        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            use zerocopy::IntoBytes as _;
            let (id_type, id) = match self {
                Self { inner: ClientIdentifierInner::Id(v) } => (CLIENT_IDENTIFIER_ID, &v[..]),
                Self { inner: ClientIdentifierInner::Chaddr(v) } => {
                    (CLIENT_IDENTIFIER_CHADDR, v.as_bytes())
                }
            };
            write!(f, "{}:{}", id_type, hex::encode(id))
        }
    }
}

/// A DHCP protocol op-code as defined in RFC 2131.
///
/// Note that this type corresponds to the first field of a DHCP message,
/// opcode, and is distinct from the OptionCode type. In this case, "Op"
/// is an abbreviation for Operator, not Option.
///
/// `OpCode::BOOTREQUEST` should only appear in protocol messages from the
/// client, and conversely `OpCode::BOOTREPLY` should only appear in messages
/// from the server.
#[derive(FromPrimitive, Copy, Clone, Debug, PartialEq)]
#[repr(u8)]
pub enum OpCode {
    BOOTREQUEST = 1,
    BOOTREPLY = 2,
}

impl fmt::Display for OpCode {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            OpCode::BOOTREQUEST => write!(f, "BOOTREQUEST"),
            OpCode::BOOTREPLY => write!(f, "BOOTREPLY"),
        }
    }
}

impl From<OpCode> for u8 {
    fn from(code: OpCode) -> u8 {
        code as u8
    }
}

impl TryFrom<u8> for OpCode {
    type Error = ProtocolError;

    fn try_from(n: u8) -> Result<Self, Self::Error> {
        <Self as num_traits::FromPrimitive>::from_u8(n).ok_or(ProtocolError::InvalidOpCode(n))
    }
}

/// A DHCP option code.
///
/// This enum corresponds to the codes for DHCP options as defined in
/// RFC 1533. Note that not all options defined in the RFC are represented
/// here; options which are not in this type are not currently supported. Supported
/// options appear in this type in the order in which they are defined in the RFC.
#[derive(
    Copy, Clone, Debug, Deserialize, Eq, FromPrimitive, Hash, PartialEq, Serialize, PartialOrd, Ord,
)]
#[repr(u8)]
pub enum OptionCode {
    Pad = 0,
    SubnetMask = 1,
    TimeOffset = 2,
    Router = 3,
    TimeServer = 4,
    NameServer = 5,
    DomainNameServer = 6,
    LogServer = 7,
    CookieServer = 8,
    LprServer = 9,
    ImpressServer = 10,
    ResourceLocationServer = 11,
    HostName = 12,
    BootFileSize = 13,
    MeritDumpFile = 14,
    DomainName = 15,
    SwapServer = 16,
    RootPath = 17,
    ExtensionsPath = 18,
    IpForwarding = 19,
    NonLocalSourceRouting = 20,
    PolicyFilter = 21,
    MaxDatagramReassemblySize = 22,
    DefaultIpTtl = 23,
    PathMtuAgingTimeout = 24,
    PathMtuPlateauTable = 25,
    InterfaceMtu = 26,
    AllSubnetsLocal = 27,
    BroadcastAddress = 28,
    PerformMaskDiscovery = 29,
    MaskSupplier = 30,
    PerformRouterDiscovery = 31,
    RouterSolicitationAddress = 32,
    StaticRoute = 33,
    TrailerEncapsulation = 34,
    ArpCacheTimeout = 35,
    EthernetEncapsulation = 36,
    TcpDefaultTtl = 37,
    TcpKeepaliveInterval = 38,
    TcpKeepaliveGarbage = 39,
    NetworkInformationServiceDomain = 40,
    NetworkInformationServers = 41,
    NetworkTimeProtocolServers = 42,
    VendorSpecificInformation = 43,
    NetBiosOverTcpipNameServer = 44,
    NetBiosOverTcpipDatagramDistributionServer = 45,
    NetBiosOverTcpipNodeType = 46,
    NetBiosOverTcpipScope = 47,
    XWindowSystemFontServer = 48,
    XWindowSystemDisplayManager = 49,
    RequestedIpAddress = 50,
    IpAddressLeaseTime = 51,
    OptionOverload = 52,
    DhcpMessageType = 53,
    ServerIdentifier = 54,
    ParameterRequestList = 55,
    Message = 56,
    MaxDhcpMessageSize = 57,
    RenewalTimeValue = 58,
    RebindingTimeValue = 59,
    VendorClassIdentifier = 60,
    ClientIdentifier = 61,
    NetworkInformationServicePlusDomain = 64,
    NetworkInformationServicePlusServers = 65,
    TftpServerName = 66,
    BootfileName = 67,
    MobileIpHomeAgent = 68,
    SmtpServer = 69,
    Pop3Server = 70,
    NntpServer = 71,
    DefaultWwwServer = 72,
    DefaultFingerServer = 73,
    DefaultIrcServer = 74,
    StreetTalkServer = 75,
    StreetTalkDirectoryAssistanceServer = 76,
    End = 255,
}

impl From<OptionCode> for u8 {
    fn from(code: OptionCode) -> u8 {
        code as u8
    }
}

impl TryFrom<u8> for OptionCode {
    type Error = ProtocolError;

    fn try_from(n: u8) -> Result<Self, Self::Error> {
        <Self as num_traits::FromPrimitive>::from_u8(n).ok_or(ProtocolError::InvalidOptionCode(n))
    }
}

impl fmt::Display for OptionCode {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        fmt::Debug::fmt(&self, f)
    }
}

mod prefix_length {
    use std::net::Ipv4Addr;

    use net_types::ip::{Ipv4, NotSubnetMaskError, PrefixLength};
    use serde::Serialize as _;
    use serde::de::{Deserialize as _, Error};

    pub(super) fn serialize<S: serde::Serializer>(
        prefix_length: &PrefixLength<Ipv4>,
        serializer: S,
    ) -> Result<S::Ok, S::Error> {
        Ipv4Addr::serialize(&Ipv4Addr::from(prefix_length.get_mask()), serializer)
    }

    pub(super) fn deserialize<'de, D: serde::Deserializer<'de>>(
        deserializer: D,
    ) -> Result<PrefixLength<Ipv4>, D::Error> {
        let addr = Ipv4Addr::deserialize(deserializer)?;
        PrefixLength::try_from_subnet_mask(addr.into())
            .map_err(|NotSubnetMaskError| D::Error::custom("not a valid subnet mask"))
    }
}

/// A DHCP Option as defined in RFC 2132.
/// DHCP Options provide a mechanism for transmitting configuration parameters
/// between the Server and Client and vice-versa. DHCP Options also include
/// some control and meta information needed for the operation of the DHCP
/// protocol but which could not be included in the DHCP header because of
/// the backwards compatibility requirement with the older BOOTP protocol.
#[derive(Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)]
pub enum DhcpOption {
    Pad(),
    End(),
    #[serde(with = "prefix_length")]
    SubnetMask(PrefixLength<Ipv4>),
    TimeOffset(i32),
    // Router must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.5
    Router(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Time Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.6
    TimeServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Name Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.7
    NameServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Domain Name Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.8
    DomainNameServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Log Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.9
    LogServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Cookie Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.10
    CookieServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // LPR Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.11
    LprServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Impress Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.12
    ImpressServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Resource Location Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-3.13
    ResourceLocationServer(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    HostName(String),
    BootFileSize(u16),
    MeritDumpFile(String),
    DomainName(String),
    SwapServer(Ipv4Addr),
    RootPath(String),
    ExtensionsPath(String),
    IpForwarding(bool),
    NonLocalSourceRouting(bool),
    // Policy Filter must have at least **2** elements and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-4.3
    PolicyFilter(AtLeast<2, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    MaxDatagramReassemblySize(u16),
    // DefaultIpTtl cannot be zero: https://datatracker.ietf.org/doc/html/rfc2132#section-4.5
    DefaultIpTtl(NonZeroU8),
    PathMtuAgingTimeout(u32),
    // Path MTU Plateau Table must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-4.7
    PathMtuPlateauTable(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<u16>>>),
    InterfaceMtu(u16),
    AllSubnetsLocal(bool),
    BroadcastAddress(Ipv4Addr),
    PerformMaskDiscovery(bool),
    MaskSupplier(bool),
    PerformRouterDiscovery(bool),
    RouterSolicitationAddress(Ipv4Addr),
    // Static Route must have at least **2** elements and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-5.8
    StaticRoute(AtLeast<2, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    TrailerEncapsulation(bool),
    ArpCacheTimeout(u32),
    EthernetEncapsulation(bool),
    // TcpDefaultTtl cannot be zero: https://datatracker.ietf.org/doc/html/rfc2132#section-7.1
    TcpDefaultTtl(NonZeroU8),
    TcpKeepaliveInterval(u32),
    TcpKeepaliveGarbage(bool),
    NetworkInformationServiceDomain(String),
    // Network Information Servers must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.2
    NetworkInformationServers(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // Network Time Protocol Servers must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.3
    NetworkTimeProtocolServers(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // Vendor Specific Information must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.4
    VendorSpecificInformation(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<u8>>>,
    ),
    // NetBIOS over TCP/IP Name Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.5
    NetBiosOverTcpipNameServer(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // NetBIOS over TCP/IP Datagram Distribution Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.6
    NetBiosOverTcpipDatagramDistributionServer(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    NetBiosOverTcpipNodeType(NodeType),
    NetBiosOverTcpipScope(String),
    // X Window System Font Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.9
    XWindowSystemFontServer(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // X Window System Display Manager must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.10
    XWindowSystemDisplayManager(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    NetworkInformationServicePlusDomain(String),
    // Network Information Service+ Servers must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.12
    NetworkInformationServicePlusServers(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // Mobile IP Home Agent has an 8-bit length field, but is allowed to have 0 elements:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.13
    MobileIpHomeAgent(
        AtLeast<0, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // SMTP Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.14
    SmtpServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // POP3 Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.15
    Pop3Server(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // NNTP Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.16
    NntpServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Default WWW Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.17
    DefaultWwwServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // Default Finger Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.18
    DefaultFingerServer(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    // Default IRC Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.19
    DefaultIrcServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // StreetTalk Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.20
    StreetTalkServer(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>),
    // StreetTalk Directory Assistance Server must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-8.21
    StreetTalkDirectoryAssistanceServer(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    ),
    RequestedIpAddress(Ipv4Addr),
    IpAddressLeaseTime(u32),
    OptionOverload(Overload),
    TftpServerName(String),
    BootfileName(String),
    DhcpMessageType(MessageType),
    ServerIdentifier(Ipv4Addr),
    // Parameter Request List must have at least 1 element and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-9.8
    ParameterRequestList(
        AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<OptionCode>>>,
    ),
    /// According to [RFC 2132 section 9.9], "The message consists of n octets
    /// of NVT ASCII text, which the client may display on an available output
    /// device". According to [RFC 3629 section 1], UTF-8 preserves US-ASCII
    /// octets.
    ///
    /// While it's somewhat ambiguous from [RFC 854] whether "NVT ASCII"
    /// includes the non-standard-7-bit-ASCII control codes or not, [RFC 698]
    /// states that "it is expected normal NVT ASCII would be used for 7-bit
    /// ASCII", suggesting that NVT ASCII does designate only the
    /// US-ASCII-compatible subset of characters that can be output by NVT
    /// terminals.
    ///
    /// Thus, it is safe to represent incoming Message options as a UTF-8 String
    /// and discard Message options that cannot be represented in UTF-8.
    ///
    /// However, _outgoing_ Message options (e.g. ones written by a DHCP server
    /// implemented using this library) must be careful to use only ASCII text
    /// rather than full UTF-8.
    ///
    /// [RFC 2132 section 9.9]: https://datatracker.ietf.org/doc/html/rfc2132#section-9.9
    /// [RFC 3629 section 1]: https://datatracker.ietf.org/doc/html/rfc3629#section-1
    /// [RFC 854]: https://datatracker.ietf.org/doc/html/rfc854
    /// [RFC 698]: https://datatracker.ietf.org/doc/html/rfc698
    Message(String),
    MaxDhcpMessageSize(u16),
    RenewalTimeValue(u32),
    RebindingTimeValue(u32),
    // Vendor Class Identifier must be at least 1 byte long and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-9.13
    VendorClassIdentifier(AtLeast<1, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<u8>>>),
    // Client Identifier must be at least **2** bytes long and has an 8-bit length field:
    // https://datatracker.ietf.org/doc/html/rfc2132#section-9.14
    ClientIdentifier(
        AtLeast<
            { CLIENT_IDENTIFIER_MINIMUM_LENGTH },
            AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<u8>>,
        >,
    ),
}

/// The minimum length, in bytes, of the Client Identifier option.
pub const CLIENT_IDENTIFIER_MINIMUM_LENGTH: usize = 2;

/// Generates a match expression on `$option` which maps each of the supplied `DhcpOption` variants
/// to their `OptionCode` equivalent.
macro_rules! option_to_code {
    ($option:ident, $(DhcpOption::$variant:tt($($v:tt)*)),*) => {
        match $option {
            $(DhcpOption::$variant($($v)*) => OptionCode::$variant,)*
        }
    };
}

impl DhcpOption {
    fn from_raw_parts(code: OptionCode, val: &[u8]) -> Result<Self, ProtocolError> {
        match code {
            OptionCode::Pad => Ok(DhcpOption::Pad()),
            OptionCode::End => Ok(DhcpOption::End()),
            OptionCode::SubnetMask => {
                let addr = bytes_to_addr(val)?;
                Ok(DhcpOption::SubnetMask(
                    PrefixLength::try_from_subnet_mask(addr.into()).map_err(
                        |NotSubnetMaskError| ProtocolError::InvalidOptionValue(code, val.to_vec()),
                    )?,
                ))
            }
            OptionCode::TimeOffset => {
                let offset = get_byte_array::<4>(val).map(i32::from_be_bytes)?;
                Ok(DhcpOption::TimeOffset(offset))
            }
            OptionCode::Router => Ok(DhcpOption::Router(bytes_to_addrs(val)?)),
            OptionCode::TimeServer => Ok(DhcpOption::TimeServer(bytes_to_addrs(val)?)),
            OptionCode::NameServer => Ok(DhcpOption::NameServer(bytes_to_addrs(val)?)),
            OptionCode::DomainNameServer => Ok(DhcpOption::DomainNameServer(bytes_to_addrs(val)?)),
            OptionCode::LogServer => Ok(DhcpOption::LogServer(bytes_to_addrs(val)?)),
            OptionCode::CookieServer => Ok(DhcpOption::CookieServer(bytes_to_addrs(val)?)),
            OptionCode::LprServer => Ok(DhcpOption::LprServer(bytes_to_addrs(val)?)),
            OptionCode::ImpressServer => Ok(DhcpOption::ImpressServer(bytes_to_addrs(val)?)),
            OptionCode::ResourceLocationServer => {
                Ok(DhcpOption::ResourceLocationServer(bytes_to_addrs(val)?))
            }
            OptionCode::HostName => Ok(DhcpOption::HostName(bytes_to_nonempty_str(val)?)),
            OptionCode::BootFileSize => {
                let size = get_byte_array::<2>(val).map(u16::from_be_bytes)?;
                Ok(DhcpOption::BootFileSize(size))
            }
            OptionCode::MeritDumpFile => Ok(DhcpOption::MeritDumpFile(bytes_to_nonempty_str(val)?)),
            OptionCode::DomainName => Ok(DhcpOption::DomainName(bytes_to_nonempty_str(val)?)),
            OptionCode::SwapServer => Ok(DhcpOption::SwapServer(bytes_to_addr(val)?)),
            OptionCode::RootPath => Ok(DhcpOption::RootPath(bytes_to_nonempty_str(val)?)),
            OptionCode::ExtensionsPath => {
                Ok(DhcpOption::ExtensionsPath(bytes_to_nonempty_str(val)?))
            }
            OptionCode::IpForwarding => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::IpForwarding(flag))
            }
            OptionCode::NonLocalSourceRouting => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::NonLocalSourceRouting(flag))
            }
            OptionCode::PolicyFilter => {
                let addrs = bytes_to_addrs(val)?;
                if addrs.len() < 2 || addrs.len() % 2 != 0 {
                    return Err(ProtocolError::InvalidBufferLength(val.len()));
                }
                Ok(DhcpOption::PolicyFilter(addrs))
            }
            OptionCode::MaxDatagramReassemblySize => {
                let max_datagram = get_byte_array::<2>(val).map(u16::from_be_bytes)?;
                if max_datagram < MIN_MESSAGE_SIZE {
                    return Err(ProtocolError::InvalidOptionValue(code, val.to_vec()));
                }
                Ok(DhcpOption::MaxDatagramReassemblySize(max_datagram))
            }
            OptionCode::DefaultIpTtl => {
                let ttl = get_byte(val)?;
                let ttl = NonZeroU8::new(ttl)
                    .ok_or_else(|| ProtocolError::InvalidOptionValue(code, val.to_vec()))?;
                Ok(DhcpOption::DefaultIpTtl(ttl))
            }
            OptionCode::PathMtuAgingTimeout => {
                let timeout = get_byte_array::<4>(val).map(u32::from_be_bytes)?;
                Ok(DhcpOption::PathMtuAgingTimeout(timeout))
            }
            OptionCode::PathMtuPlateauTable => {
                let mtus = val
                    .chunks(2)
                    .map(|chunk| get_byte_array::<2>(chunk).map(u16::from_be_bytes))
                    .collect::<Result<Vec<u16>, InvalidBufferLengthError>>()
                    .map_err(|InvalidBufferLengthError(_)| {
                        ProtocolError::InvalidBufferLength(val.len())
                    })?;
                Ok(DhcpOption::PathMtuPlateauTable(mtus.try_into().map_err(
                    |(size_constrained::Error::SizeConstraintViolated, _)| {
                        ProtocolError::InvalidBufferLength(val.len())
                    },
                )?))
            }
            OptionCode::InterfaceMtu => {
                let mtu = get_byte_array::<2>(val).map(u16::from_be_bytes)?;
                if mtu < MIN_MTU_VAL {
                    return Err(ProtocolError::InvalidOptionValue(code, val.to_vec()));
                }
                Ok(DhcpOption::InterfaceMtu(mtu))
            }
            OptionCode::AllSubnetsLocal => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::AllSubnetsLocal(flag))
            }
            OptionCode::BroadcastAddress => Ok(DhcpOption::BroadcastAddress(bytes_to_addr(val)?)),
            OptionCode::PerformMaskDiscovery => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::PerformMaskDiscovery(flag))
            }
            OptionCode::MaskSupplier => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::MaskSupplier(flag))
            }
            OptionCode::PerformRouterDiscovery => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::PerformRouterDiscovery(flag))
            }
            OptionCode::RouterSolicitationAddress => {
                Ok(DhcpOption::RouterSolicitationAddress(bytes_to_addr(val)?))
            }
            OptionCode::StaticRoute => {
                let addrs = bytes_to_addrs(val)?;
                if addrs.len() < 2 || addrs.len() % 2 != 0 {
                    return Err(ProtocolError::InvalidBufferLength(val.len()));
                }
                Ok(DhcpOption::StaticRoute(addrs))
            }
            OptionCode::TrailerEncapsulation => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::TrailerEncapsulation(flag))
            }
            OptionCode::ArpCacheTimeout => {
                let timeout = get_byte_array::<4>(val).map(u32::from_be_bytes)?;
                Ok(DhcpOption::ArpCacheTimeout(timeout))
            }
            OptionCode::EthernetEncapsulation => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::EthernetEncapsulation(flag))
            }
            OptionCode::TcpDefaultTtl => {
                let ttl = get_byte(val)?;
                let ttl = NonZeroU8::new(ttl)
                    .ok_or_else(|| ProtocolError::InvalidOptionValue(code, val.to_vec()))?;
                Ok(DhcpOption::TcpDefaultTtl(ttl))
            }
            OptionCode::TcpKeepaliveInterval => {
                let interval = get_byte_array::<4>(val).map(u32::from_be_bytes)?;
                Ok(DhcpOption::TcpKeepaliveInterval(interval))
            }
            OptionCode::TcpKeepaliveGarbage => {
                let flag = bytes_to_bool(val).map_err(|e| e.to_protocol(code))?;
                Ok(DhcpOption::TcpKeepaliveGarbage(flag))
            }
            OptionCode::NetworkInformationServiceDomain => {
                let name = bytes_to_nonempty_str(val)?;
                Ok(DhcpOption::NetworkInformationServiceDomain(name))
            }
            OptionCode::NetworkInformationServers => {
                Ok(DhcpOption::NetworkInformationServers(bytes_to_addrs(val)?))
            }
            OptionCode::NetworkTimeProtocolServers => {
                Ok(DhcpOption::NetworkTimeProtocolServers(bytes_to_addrs(val)?))
            }
            OptionCode::VendorSpecificInformation => {
                Ok(DhcpOption::VendorSpecificInformation(val.to_owned().try_into().map_err(
                    |(size_constrained::Error::SizeConstraintViolated, _)| {
                        ProtocolError::InvalidBufferLength(val.len())
                    },
                )?))
            }
            OptionCode::NetBiosOverTcpipNameServer => {
                Ok(DhcpOption::NetBiosOverTcpipNameServer(bytes_to_addrs(val)?))
            }
            OptionCode::NetBiosOverTcpipDatagramDistributionServer => {
                Ok(DhcpOption::NetBiosOverTcpipDatagramDistributionServer(bytes_to_addrs(val)?))
            }
            OptionCode::NetBiosOverTcpipNodeType => {
                let byte = get_byte(val)?;
                Ok(DhcpOption::NetBiosOverTcpipNodeType(NodeType::try_from(byte)?))
            }
            OptionCode::NetBiosOverTcpipScope => {
                Ok(DhcpOption::NetBiosOverTcpipScope(bytes_to_nonempty_str(val)?))
            }
            OptionCode::XWindowSystemFontServer => {
                Ok(DhcpOption::XWindowSystemFontServer(bytes_to_addrs(val)?))
            }
            OptionCode::XWindowSystemDisplayManager => {
                Ok(DhcpOption::XWindowSystemDisplayManager(bytes_to_addrs(val)?))
            }
            OptionCode::NetworkInformationServicePlusDomain => {
                Ok(DhcpOption::NetworkInformationServicePlusDomain(bytes_to_nonempty_str(val)?))
            }
            OptionCode::NetworkInformationServicePlusServers => {
                Ok(DhcpOption::NetworkInformationServicePlusServers(bytes_to_addrs(val)?))
            }
            OptionCode::MobileIpHomeAgent => {
                Ok(DhcpOption::MobileIpHomeAgent(bytes_to_addrs(val)?))
            }
            OptionCode::SmtpServer => Ok(DhcpOption::SmtpServer(bytes_to_addrs(val)?)),
            OptionCode::Pop3Server => Ok(DhcpOption::Pop3Server(bytes_to_addrs(val)?)),
            OptionCode::NntpServer => Ok(DhcpOption::NntpServer(bytes_to_addrs(val)?)),
            OptionCode::DefaultWwwServer => Ok(DhcpOption::DefaultWwwServer(bytes_to_addrs(val)?)),
            OptionCode::DefaultFingerServer => {
                Ok(DhcpOption::DefaultFingerServer(bytes_to_addrs(val)?))
            }
            OptionCode::DefaultIrcServer => Ok(DhcpOption::DefaultIrcServer(bytes_to_addrs(val)?)),
            OptionCode::StreetTalkServer => Ok(DhcpOption::StreetTalkServer(bytes_to_addrs(val)?)),
            OptionCode::StreetTalkDirectoryAssistanceServer => {
                Ok(DhcpOption::StreetTalkDirectoryAssistanceServer(bytes_to_addrs(val)?))
            }
            OptionCode::RequestedIpAddress => {
                Ok(DhcpOption::RequestedIpAddress(bytes_to_addr(val)?))
            }
            OptionCode::IpAddressLeaseTime => {
                let lease_time = get_byte_array::<4>(val).map(u32::from_be_bytes)?;
                Ok(DhcpOption::IpAddressLeaseTime(lease_time))
            }
            OptionCode::OptionOverload => {
                let overload = Overload::try_from(
                    *val.first().ok_or(ProtocolError::InvalidBufferLength(val.len()))?,
                )?;
                Ok(DhcpOption::OptionOverload(overload))
            }
            OptionCode::TftpServerName => {
                let name = bytes_to_nonempty_str(val)?;
                Ok(DhcpOption::TftpServerName(name))
            }
            OptionCode::BootfileName => {
                let name = bytes_to_nonempty_str(val)?;
                Ok(DhcpOption::BootfileName(name))
            }
            OptionCode::DhcpMessageType => {
                let message_type = MessageType::try_from(
                    *val.first().ok_or(ProtocolError::InvalidBufferLength(val.len()))?,
                )?;
                Ok(DhcpOption::DhcpMessageType(message_type))
            }
            OptionCode::ServerIdentifier => Ok(DhcpOption::ServerIdentifier(bytes_to_addr(val)?)),
            OptionCode::ParameterRequestList => {
                let opcodes = val
                    .iter()
                    .filter_map(|code| OptionCode::try_from(*code).ok())
                    .collect::<Vec<_>>();
                // Note that if we don't recognize any of the OptionCodes, we'll return Err rather
                // than Ok(empty parameter request list) here. This isn't strictly correct, as the
                // raw Parameter Request List is indeed nonempty as required by
                // https://www.rfc-editor.org/rfc/rfc2132#section-9.8, even though we don't
                // recognize any of the option codes in it. However, our usages of this fn
                // interpret an invalid option the same way they interpret the absence of that
                // option, so this is not an issue.
                Ok(DhcpOption::ParameterRequestList(opcodes.try_into().map_err(
                    |(size_constrained::Error::SizeConstraintViolated, _)| {
                        ProtocolError::InvalidBufferLength(val.len())
                    },
                )?))
            }
            OptionCode::Message => Ok(DhcpOption::Message(bytes_to_nonempty_str(val)?)),
            OptionCode::MaxDhcpMessageSize => {
                let max_size = get_byte_array::<2>(val).map(u16::from_be_bytes)?;
                if max_size < MIN_MESSAGE_SIZE {
                    return Err(ProtocolError::InvalidOptionValue(code, val.to_vec()));
                }
                Ok(DhcpOption::MaxDhcpMessageSize(max_size))
            }
            OptionCode::RenewalTimeValue => {
                let renewal_time = get_byte_array::<4>(val).map(u32::from_be_bytes)?;
                Ok(DhcpOption::RenewalTimeValue(renewal_time))
            }
            OptionCode::RebindingTimeValue => {
                let rebinding_time = get_byte_array::<4>(val).map(u32::from_be_bytes)?;
                Ok(DhcpOption::RebindingTimeValue(rebinding_time))
            }
            OptionCode::VendorClassIdentifier => {
                Ok(DhcpOption::VendorClassIdentifier(val.to_owned().try_into().map_err(
                    |(size_constrained::Error::SizeConstraintViolated, _)| {
                        ProtocolError::InvalidBufferLength(val.len())
                    },
                )?))
            }
            OptionCode::ClientIdentifier => {
                // Client Identifier must be at least two bytes.
                // https://datatracker.ietf.org/doc/html/rfc2132#section-9.14
                if val.len() < 2 {
                    return Err(ProtocolError::InvalidBufferLength(val.len()));
                }
                Ok(DhcpOption::ClientIdentifier(val.to_owned().try_into().map_err(
                    |(size_constrained::Error::SizeConstraintViolated, _)| {
                        ProtocolError::InvalidBufferLength(val.len())
                    },
                )?))
            }
        }
    }

    fn serialize_to(self, buf: &mut Vec<u8>) {
        let code = self.code();
        match self {
            DhcpOption::Pad() => buf.push(code.into()),
            DhcpOption::End() => buf.push(code.into()),
            DhcpOption::SubnetMask(v) => serialize_address(code, v.get_mask().into(), buf),
            DhcpOption::TimeOffset(v) => {
                let size = std::mem::size_of::<i32>();
                buf.push(code.into());
                buf.push(u8::try_from(size).expect("size did not fit in u8"));
                buf.extend_from_slice(&v.to_be_bytes());
            }
            DhcpOption::Router(v) => serialize_addresses(code, &v, buf),
            DhcpOption::TimeServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::NameServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::DomainNameServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::LogServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::CookieServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::LprServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::ImpressServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::ResourceLocationServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::HostName(v) => serialize_string(code, &v, buf),
            DhcpOption::BootFileSize(v) => serialize_u16(code, v, buf),
            DhcpOption::MeritDumpFile(v) => serialize_string(code, &v, buf),
            DhcpOption::DomainName(v) => serialize_string(code, &v, buf),
            DhcpOption::SwapServer(v) => serialize_address(code, v, buf),
            DhcpOption::RootPath(v) => serialize_string(code, &v, buf),
            DhcpOption::ExtensionsPath(v) => serialize_string(code, &v, buf),
            DhcpOption::IpForwarding(v) => serialize_flag(code, v, buf),
            DhcpOption::NonLocalSourceRouting(v) => serialize_flag(code, v, buf),
            DhcpOption::PolicyFilter(v) => serialize_addresses(code, &v, buf),
            DhcpOption::MaxDatagramReassemblySize(v) => serialize_u16(code, v, buf),
            DhcpOption::DefaultIpTtl(v) => serialize_u8(code, v.into(), buf),
            DhcpOption::PathMtuAgingTimeout(v) => serialize_u32(code, v, buf),
            DhcpOption::PathMtuPlateauTable(v) => {
                let size = v.size_of_contents_in_bytes();
                buf.push(code.into());
                buf.push(u8::try_from(size).expect("size did not fit in u8"));
                for mtu in v {
                    buf.extend_from_slice(&mtu.to_be_bytes())
                }
            }
            DhcpOption::InterfaceMtu(v) => serialize_u16(code, v, buf),
            DhcpOption::AllSubnetsLocal(v) => serialize_flag(code, v, buf),
            DhcpOption::BroadcastAddress(v) => serialize_address(code, v, buf),
            DhcpOption::PerformMaskDiscovery(v) => serialize_flag(code, v, buf),
            DhcpOption::MaskSupplier(v) => serialize_flag(code, v, buf),
            DhcpOption::PerformRouterDiscovery(v) => serialize_flag(code, v, buf),
            DhcpOption::RouterSolicitationAddress(v) => serialize_address(code, v, buf),
            DhcpOption::StaticRoute(v) => serialize_addresses(code, &v, buf),
            DhcpOption::TrailerEncapsulation(v) => serialize_flag(code, v, buf),
            DhcpOption::ArpCacheTimeout(v) => serialize_u32(code, v, buf),
            DhcpOption::EthernetEncapsulation(v) => serialize_flag(code, v, buf),
            DhcpOption::TcpDefaultTtl(v) => serialize_u8(code, v.into(), buf),
            DhcpOption::TcpKeepaliveInterval(v) => serialize_u32(code, v, buf),
            DhcpOption::TcpKeepaliveGarbage(v) => serialize_flag(code, v, buf),
            DhcpOption::NetworkInformationServiceDomain(v) => serialize_string(code, &v, buf),
            DhcpOption::NetworkInformationServers(v) => serialize_addresses(code, &v, buf),
            DhcpOption::NetworkTimeProtocolServers(v) => serialize_addresses(code, &v, buf),
            DhcpOption::VendorSpecificInformation(v) => serialize_bytes(code, &v, buf),
            DhcpOption::NetBiosOverTcpipNameServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::NetBiosOverTcpipDatagramDistributionServer(v) => {
                serialize_addresses(code, &v, buf)
            }
            DhcpOption::NetBiosOverTcpipNodeType(v) => serialize_enum(code, v, buf),
            DhcpOption::NetBiosOverTcpipScope(v) => serialize_string(code, &v, buf),
            DhcpOption::XWindowSystemFontServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::XWindowSystemDisplayManager(v) => serialize_addresses(code, &v, buf),
            DhcpOption::NetworkInformationServicePlusDomain(v) => serialize_string(code, &v, buf),
            DhcpOption::NetworkInformationServicePlusServers(v) => {
                serialize_addresses(code, &v, buf)
            }
            DhcpOption::MobileIpHomeAgent(v) => serialize_addresses(code, &v, buf),
            DhcpOption::SmtpServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::Pop3Server(v) => serialize_addresses(code, &v, buf),
            DhcpOption::NntpServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::DefaultWwwServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::DefaultFingerServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::DefaultIrcServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::StreetTalkServer(v) => serialize_addresses(code, &v, buf),
            DhcpOption::StreetTalkDirectoryAssistanceServer(v) => {
                serialize_addresses(code, &v, buf)
            }
            DhcpOption::RequestedIpAddress(v) => serialize_address(code, v, buf),
            DhcpOption::IpAddressLeaseTime(v) => serialize_u32(code, v, buf),
            DhcpOption::OptionOverload(v) => serialize_enum(code, v, buf),
            DhcpOption::TftpServerName(v) => serialize_string(code, &v, buf),
            DhcpOption::BootfileName(v) => serialize_string(code, &v, buf),
            DhcpOption::DhcpMessageType(v) => serialize_enum(code, v, buf),
            DhcpOption::ServerIdentifier(v) => serialize_address(code, v, buf),
            DhcpOption::ParameterRequestList(v) => {
                let v = Vec::from(v);
                let size = v.size_of_contents_in_bytes();
                buf.push(code.into());
                buf.push(u8::try_from(size).expect("size did not fit in u8"));
                buf.extend(v.into_iter().map(u8::from));
            }
            DhcpOption::Message(v) => serialize_string(code, &v, buf),
            DhcpOption::MaxDhcpMessageSize(v) => serialize_u16(code, v, buf),
            DhcpOption::RenewalTimeValue(v) => serialize_u32(code, v, buf),
            DhcpOption::RebindingTimeValue(v) => serialize_u32(code, v, buf),
            DhcpOption::VendorClassIdentifier(v) => serialize_bytes(code, &v, buf),
            DhcpOption::ClientIdentifier(v) => serialize_bytes(code, &v, buf),
        }
    }

    /// Returns the `OptionCode` variant corresponding to `self`.
    pub fn code(&self) -> OptionCode {
        option_to_code!(
            self,
            DhcpOption::Pad(),
            DhcpOption::End(),
            DhcpOption::SubnetMask(_),
            DhcpOption::TimeOffset(_),
            DhcpOption::Router(_),
            DhcpOption::TimeServer(_),
            DhcpOption::NameServer(_),
            DhcpOption::DomainNameServer(_),
            DhcpOption::LogServer(_),
            DhcpOption::CookieServer(_),
            DhcpOption::LprServer(_),
            DhcpOption::ImpressServer(_),
            DhcpOption::ResourceLocationServer(_),
            DhcpOption::HostName(_),
            DhcpOption::BootFileSize(_),
            DhcpOption::MeritDumpFile(_),
            DhcpOption::DomainName(_),
            DhcpOption::SwapServer(_),
            DhcpOption::RootPath(_),
            DhcpOption::ExtensionsPath(_),
            DhcpOption::IpForwarding(_),
            DhcpOption::NonLocalSourceRouting(_),
            DhcpOption::PolicyFilter(_),
            DhcpOption::MaxDatagramReassemblySize(_),
            DhcpOption::DefaultIpTtl(_),
            DhcpOption::PathMtuAgingTimeout(_),
            DhcpOption::PathMtuPlateauTable(_),
            DhcpOption::InterfaceMtu(_),
            DhcpOption::AllSubnetsLocal(_),
            DhcpOption::BroadcastAddress(_),
            DhcpOption::PerformMaskDiscovery(_),
            DhcpOption::MaskSupplier(_),
            DhcpOption::PerformRouterDiscovery(_),
            DhcpOption::RouterSolicitationAddress(_),
            DhcpOption::StaticRoute(_),
            DhcpOption::TrailerEncapsulation(_),
            DhcpOption::ArpCacheTimeout(_),
            DhcpOption::EthernetEncapsulation(_),
            DhcpOption::TcpDefaultTtl(_),
            DhcpOption::TcpKeepaliveInterval(_),
            DhcpOption::TcpKeepaliveGarbage(_),
            DhcpOption::NetworkInformationServiceDomain(_),
            DhcpOption::NetworkInformationServers(_),
            DhcpOption::NetworkTimeProtocolServers(_),
            DhcpOption::VendorSpecificInformation(_),
            DhcpOption::NetBiosOverTcpipNameServer(_),
            DhcpOption::NetBiosOverTcpipDatagramDistributionServer(_),
            DhcpOption::NetBiosOverTcpipNodeType(_),
            DhcpOption::NetBiosOverTcpipScope(_),
            DhcpOption::XWindowSystemFontServer(_),
            DhcpOption::XWindowSystemDisplayManager(_),
            DhcpOption::NetworkInformationServicePlusDomain(_),
            DhcpOption::NetworkInformationServicePlusServers(_),
            DhcpOption::MobileIpHomeAgent(_),
            DhcpOption::SmtpServer(_),
            DhcpOption::Pop3Server(_),
            DhcpOption::NntpServer(_),
            DhcpOption::DefaultWwwServer(_),
            DhcpOption::DefaultFingerServer(_),
            DhcpOption::DefaultIrcServer(_),
            DhcpOption::StreetTalkServer(_),
            DhcpOption::StreetTalkDirectoryAssistanceServer(_),
            DhcpOption::RequestedIpAddress(_),
            DhcpOption::IpAddressLeaseTime(_),
            DhcpOption::OptionOverload(_),
            DhcpOption::TftpServerName(_),
            DhcpOption::BootfileName(_),
            DhcpOption::DhcpMessageType(_),
            DhcpOption::ServerIdentifier(_),
            DhcpOption::ParameterRequestList(_),
            DhcpOption::Message(_),
            DhcpOption::MaxDhcpMessageSize(_),
            DhcpOption::RenewalTimeValue(_),
            DhcpOption::RebindingTimeValue(_),
            DhcpOption::VendorClassIdentifier(_),
            DhcpOption::ClientIdentifier(_)
        )
    }
}

fn serialize_address(code: OptionCode, addr: Ipv4Addr, buf: &mut Vec<u8>) {
    serialize_addresses(code, &[addr], buf);
}

fn serialize_addresses(code: OptionCode, addrs: &[Ipv4Addr], buf: &mut Vec<u8>) {
    let size = addrs.size_of_contents_in_bytes();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    for addr in addrs {
        buf.extend_from_slice(&addr.octets());
    }
}

fn serialize_string(code: OptionCode, string: &str, buf: &mut Vec<u8>) {
    let size = string.len();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.extend_from_slice(string.as_bytes());
}

fn serialize_flag(code: OptionCode, flag: bool, buf: &mut Vec<u8>) {
    let size = std::mem::size_of::<bool>();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.push(flag.into());
}

fn serialize_u16(code: OptionCode, v: u16, buf: &mut Vec<u8>) {
    let size = std::mem::size_of::<u16>();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.extend_from_slice(&v.to_be_bytes());
}

fn serialize_u8(code: OptionCode, v: u8, buf: &mut Vec<u8>) {
    let size = std::mem::size_of::<u8>();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.push(v);
}

fn serialize_u32(code: OptionCode, v: u32, buf: &mut Vec<u8>) {
    let size = std::mem::size_of::<u32>();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.extend_from_slice(&v.to_be_bytes());
}

fn serialize_bytes(code: OptionCode, v: &[u8], buf: &mut Vec<u8>) {
    let size = v.size_of_contents_in_bytes();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.extend_from_slice(v);
}

fn serialize_enum<T: Into<u8>>(code: OptionCode, v: T, buf: &mut Vec<u8>) {
    let size = std::mem::size_of::<T>();
    buf.push(code.into());
    buf.push(u8::try_from(size).expect("size did not fit in u8"));
    buf.push(v.into());
}

/// A type which can be converted to and from a FIDL type `F`.
#[cfg(target_os = "fuchsia")]
pub trait FidlCompatible<F>: Sized {
    type FromError;
    type IntoError;

    fn try_from_fidl(fidl: F) -> Result<Self, Self::FromError>;
    fn try_into_fidl(self) -> Result<F, Self::IntoError>;
}

/// Utility trait for infallible FIDL conversion.
#[cfg(target_os = "fuchsia")]
pub trait FromFidlExt<F>: FidlCompatible<F, FromError = Never> {
    fn from_fidl(fidl: F) -> Self {
        match Self::try_from_fidl(fidl) {
            Ok(slf) => slf,
        }
    }
}

/// Utility trait for infallible FIDL conversion.
#[cfg(target_os = "fuchsia")]
pub trait IntoFidlExt<F>: FidlCompatible<F, IntoError = Never> {
    fn into_fidl(self) -> F {
        match self.try_into_fidl() {
            Ok(fidl) => fidl,
        }
    }
}

#[cfg(target_os = "fuchsia")]
impl<F, C: FidlCompatible<F, IntoError = Never>> IntoFidlExt<F> for C {}
#[cfg(target_os = "fuchsia")]
impl<F, C: FidlCompatible<F, FromError = Never>> FromFidlExt<F> for C {}

#[cfg(target_os = "fuchsia")]
impl FidlCompatible<fidl_fuchsia_net::Ipv4Address> for Ipv4Addr {
    type FromError = Never;
    type IntoError = Never;

    fn try_from_fidl(fidl: fidl_fuchsia_net::Ipv4Address) -> Result<Self, Self::FromError> {
        Ok(Ipv4Addr::from(fidl.addr))
    }

    fn try_into_fidl(self) -> Result<fidl_fuchsia_net::Ipv4Address, Self::IntoError> {
        Ok(fidl_fuchsia_net::Ipv4Address { addr: self.octets() })
    }
}

#[cfg(target_os = "fuchsia")]
impl FidlCompatible<Vec<fidl_fuchsia_net::Ipv4Address>> for Vec<Ipv4Addr> {
    type FromError = Never;
    type IntoError = Never;

    fn try_from_fidl(fidl: Vec<fidl_fuchsia_net::Ipv4Address>) -> Result<Self, Self::FromError> {
        Ok(fidl
            .into_iter()
            .filter_map(|addr| Ipv4Addr::try_from_fidl(addr).ok())
            .collect::<Vec<Ipv4Addr>>())
    }

    fn try_into_fidl(self) -> Result<Vec<fidl_fuchsia_net::Ipv4Address>, Self::IntoError> {
        Ok(self
            .into_iter()
            .filter_map(|addr| addr.try_into_fidl().ok())
            .collect::<Vec<fidl_fuchsia_net::Ipv4Address>>())
    }
}

// TODO(atait): Consider using a macro to reduce/eliminate the boilerplate in these implementations.
#[cfg(target_os = "fuchsia")]
impl FidlCompatible<fidl_fuchsia_net_dhcp::Option_> for DhcpOption {
    type FromError = ProtocolError;
    type IntoError = ProtocolError;

    fn try_into_fidl(self) -> Result<fidl_fuchsia_net_dhcp::Option_, Self::IntoError> {
        match self {
            DhcpOption::Pad() => Err(Self::IntoError::InvalidFidlOption(self)),
            DhcpOption::End() => Err(Self::IntoError::InvalidFidlOption(self)),
            DhcpOption::SubnetMask(v) => Ok(fidl_fuchsia_net_dhcp::Option_::SubnetMask(
                Ipv4Addr::from(v.get_mask()).into_fidl(),
            )),
            DhcpOption::TimeOffset(v) => Ok(fidl_fuchsia_net_dhcp::Option_::TimeOffset(v)),
            DhcpOption::Router(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::Router(Vec::from(v).into_fidl()))
            }
            DhcpOption::TimeServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::TimeServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::NameServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NameServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::DomainNameServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::DomainNameServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::LogServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::LogServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::CookieServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::CookieServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::LprServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::LprServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::ImpressServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::ImpressServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::ResourceLocationServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::ResourceLocationServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::HostName(v) => Ok(fidl_fuchsia_net_dhcp::Option_::HostName(v)),
            DhcpOption::BootFileSize(v) => Ok(fidl_fuchsia_net_dhcp::Option_::BootFileSize(v)),
            DhcpOption::MeritDumpFile(v) => Ok(fidl_fuchsia_net_dhcp::Option_::MeritDumpFile(v)),
            DhcpOption::DomainName(v) => Ok(fidl_fuchsia_net_dhcp::Option_::DomainName(v)),
            DhcpOption::SwapServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::SwapServer(v.into_fidl()))
            }
            DhcpOption::RootPath(v) => Ok(fidl_fuchsia_net_dhcp::Option_::RootPath(v)),
            DhcpOption::ExtensionsPath(v) => Ok(fidl_fuchsia_net_dhcp::Option_::ExtensionsPath(v)),
            DhcpOption::IpForwarding(v) => Ok(fidl_fuchsia_net_dhcp::Option_::IpForwarding(v)),
            DhcpOption::NonLocalSourceRouting(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NonLocalSourceRouting(v))
            }
            DhcpOption::PolicyFilter(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::PolicyFilter(Vec::from(v).into_fidl()))
            }
            DhcpOption::MaxDatagramReassemblySize(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::MaxDatagramReassemblySize(v))
            }
            DhcpOption::DefaultIpTtl(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::DefaultIpTtl(v.into()))
            }
            DhcpOption::PathMtuAgingTimeout(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::PathMtuAgingTimeout(v))
            }
            DhcpOption::PathMtuPlateauTable(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::PathMtuPlateauTable(v.into()))
            }
            DhcpOption::InterfaceMtu(v) => Ok(fidl_fuchsia_net_dhcp::Option_::InterfaceMtu(v)),
            DhcpOption::AllSubnetsLocal(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::AllSubnetsLocal(v))
            }
            DhcpOption::BroadcastAddress(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::BroadcastAddress(v.into_fidl()))
            }
            DhcpOption::PerformMaskDiscovery(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::PerformMaskDiscovery(v))
            }
            DhcpOption::MaskSupplier(v) => Ok(fidl_fuchsia_net_dhcp::Option_::MaskSupplier(v)),
            DhcpOption::PerformRouterDiscovery(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::PerformRouterDiscovery(v))
            }
            DhcpOption::RouterSolicitationAddress(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::RouterSolicitationAddress(v.into_fidl()))
            }
            DhcpOption::StaticRoute(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::StaticRoute(Vec::from(v).into_fidl()))
            }
            DhcpOption::TrailerEncapsulation(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::TrailerEncapsulation(v))
            }
            DhcpOption::ArpCacheTimeout(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::ArpCacheTimeout(v))
            }
            DhcpOption::EthernetEncapsulation(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::EthernetEncapsulation(v))
            }
            DhcpOption::TcpDefaultTtl(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::TcpDefaultTtl(v.into()))
            }
            DhcpOption::TcpKeepaliveInterval(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::TcpKeepaliveInterval(v))
            }
            DhcpOption::TcpKeepaliveGarbage(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::TcpKeepaliveGarbage(v))
            }
            DhcpOption::NetworkInformationServiceDomain(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetworkInformationServiceDomain(v))
            }
            DhcpOption::NetworkInformationServers(v) => Ok(
                fidl_fuchsia_net_dhcp::Option_::NetworkInformationServers(Vec::from(v).into_fidl()),
            ),
            DhcpOption::NetworkTimeProtocolServers(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetworkTimeProtocolServers(
                    Vec::from(v).into_fidl(),
                ))
            }
            DhcpOption::VendorSpecificInformation(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::VendorSpecificInformation(v.into()))
            }
            DhcpOption::NetBiosOverTcpipNameServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipNameServer(
                    Vec::from(v).into_fidl(),
                ))
            }
            DhcpOption::NetBiosOverTcpipDatagramDistributionServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipDatagramDistributionServer(
                    Vec::from(v).into_fidl(),
                ))
            }
            DhcpOption::NetBiosOverTcpipNodeType(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipNodeType(v.into_fidl()))
            }
            DhcpOption::NetBiosOverTcpipScope(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipScope(v))
            }
            DhcpOption::XWindowSystemFontServer(v) => Ok(
                fidl_fuchsia_net_dhcp::Option_::XWindowSystemFontServer(Vec::from(v).into_fidl()),
            ),
            DhcpOption::XWindowSystemDisplayManager(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::XWindowSystemDisplayManager(
                    Vec::from(v).into_fidl(),
                ))
            }
            DhcpOption::NetworkInformationServicePlusDomain(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetworkInformationServicePlusDomain(v))
            }
            DhcpOption::NetworkInformationServicePlusServers(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NetworkInformationServicePlusServers(
                    Vec::from(v).into_fidl(),
                ))
            }
            DhcpOption::MobileIpHomeAgent(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::MobileIpHomeAgent(Vec::from(v).into_fidl()))
            }
            DhcpOption::SmtpServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::SmtpServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::Pop3Server(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::Pop3Server(Vec::from(v).into_fidl()))
            }
            DhcpOption::NntpServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::NntpServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::DefaultWwwServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::DefaultWwwServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::DefaultFingerServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::DefaultFingerServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::DefaultIrcServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::DefaultIrcServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::StreetTalkServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::StreettalkServer(Vec::from(v).into_fidl()))
            }
            DhcpOption::StreetTalkDirectoryAssistanceServer(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::StreettalkDirectoryAssistanceServer(
                    Vec::from(v).into_fidl(),
                ))
            }
            DhcpOption::RequestedIpAddress(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::IpAddressLeaseTime(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::OptionOverload(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::OptionOverload(v.into_fidl()))
            }
            DhcpOption::TftpServerName(v) => Ok(fidl_fuchsia_net_dhcp::Option_::TftpServerName(v)),
            DhcpOption::BootfileName(v) => Ok(fidl_fuchsia_net_dhcp::Option_::BootfileName(v)),
            DhcpOption::DhcpMessageType(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::ServerIdentifier(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::ParameterRequestList(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::Message(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::MaxDhcpMessageSize(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::MaxDhcpMessageSize(v))
            }
            DhcpOption::RenewalTimeValue(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::RenewalTimeValue(v))
            }
            DhcpOption::RebindingTimeValue(v) => {
                Ok(fidl_fuchsia_net_dhcp::Option_::RebindingTimeValue(v))
            }
            DhcpOption::VendorClassIdentifier(_) => Err(ProtocolError::InvalidFidlOption(self)),
            DhcpOption::ClientIdentifier(_) => Err(ProtocolError::InvalidFidlOption(self)),
        }
    }

    fn try_from_fidl(v: fidl_fuchsia_net_dhcp::Option_) -> Result<Self, Self::FromError> {
        match v {
            fidl_fuchsia_net_dhcp::Option_::SubnetMask(v) => {
                let addr = Ipv4Addr::from_fidl(v);
                Ok(DhcpOption::SubnetMask(
                    PrefixLength::try_from_subnet_mask(addr.into()).map_err(
                        |NotSubnetMaskError| {
                            ProtocolError::InvalidOptionValue(
                                OptionCode::SubnetMask,
                                addr.octets().to_vec(),
                            )
                        },
                    )?,
                ))
            }
            fidl_fuchsia_net_dhcp::Option_::TimeOffset(v) => Ok(DhcpOption::TimeOffset(v)),
            fidl_fuchsia_net_dhcp::Option_::Router(v) => Ok(DhcpOption::Router({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::TimeServer(v) => Ok(DhcpOption::TimeServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::NameServer(v) => Ok(DhcpOption::NameServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::DomainNameServer(v) => {
                Ok(DhcpOption::DomainNameServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::LogServer(v) => Ok(DhcpOption::LogServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::CookieServer(v) => Ok(DhcpOption::CookieServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::LprServer(v) => Ok(DhcpOption::LprServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::ImpressServer(v) => Ok(DhcpOption::ImpressServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::ResourceLocationServer(v) => {
                Ok(DhcpOption::ResourceLocationServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::HostName(v) => Ok(DhcpOption::HostName(v)),
            fidl_fuchsia_net_dhcp::Option_::BootFileSize(v) => Ok(DhcpOption::BootFileSize(v)),
            fidl_fuchsia_net_dhcp::Option_::MeritDumpFile(v) => Ok(DhcpOption::MeritDumpFile(v)),
            fidl_fuchsia_net_dhcp::Option_::DomainName(v) => Ok(DhcpOption::DomainName(v)),
            fidl_fuchsia_net_dhcp::Option_::SwapServer(v) => {
                Ok(DhcpOption::SwapServer(Ipv4Addr::from_fidl(v)))
            }
            fidl_fuchsia_net_dhcp::Option_::RootPath(v) => Ok(DhcpOption::RootPath(v)),
            fidl_fuchsia_net_dhcp::Option_::ExtensionsPath(v) => Ok(DhcpOption::ExtensionsPath(v)),
            fidl_fuchsia_net_dhcp::Option_::IpForwarding(v) => Ok(DhcpOption::IpForwarding(v)),
            fidl_fuchsia_net_dhcp::Option_::NonLocalSourceRouting(v) => {
                Ok(DhcpOption::NonLocalSourceRouting(v))
            }
            fidl_fuchsia_net_dhcp::Option_::PolicyFilter(v) => Ok(DhcpOption::PolicyFilter({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::MaxDatagramReassemblySize(v) => {
                Ok(DhcpOption::MaxDatagramReassemblySize(v))
            }
            fidl_fuchsia_net_dhcp::Option_::DefaultIpTtl(v) => {
                let ttl = NonZeroU8::new(v).ok_or_else(|| {
                    ProtocolError::InvalidOptionValue(OptionCode::DefaultIpTtl, vec![v])
                })?;
                Ok(DhcpOption::DefaultIpTtl(ttl))
            }
            fidl_fuchsia_net_dhcp::Option_::PathMtuAgingTimeout(v) => {
                Ok(DhcpOption::PathMtuAgingTimeout(v))
            }
            fidl_fuchsia_net_dhcp::Option_::PathMtuPlateauTable(v) => {
                Ok(DhcpOption::PathMtuPlateauTable({
                    let size = v.size_of_contents_in_bytes();
                    v.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::InterfaceMtu(v) => Ok(DhcpOption::InterfaceMtu(v)),
            fidl_fuchsia_net_dhcp::Option_::AllSubnetsLocal(v) => {
                Ok(DhcpOption::AllSubnetsLocal(v))
            }
            fidl_fuchsia_net_dhcp::Option_::BroadcastAddress(v) => {
                Ok(DhcpOption::BroadcastAddress(Ipv4Addr::from_fidl(v)))
            }
            fidl_fuchsia_net_dhcp::Option_::PerformMaskDiscovery(v) => {
                Ok(DhcpOption::PerformMaskDiscovery(v))
            }
            fidl_fuchsia_net_dhcp::Option_::MaskSupplier(v) => Ok(DhcpOption::MaskSupplier(v)),
            fidl_fuchsia_net_dhcp::Option_::PerformRouterDiscovery(v) => {
                Ok(DhcpOption::PerformRouterDiscovery(v))
            }
            fidl_fuchsia_net_dhcp::Option_::RouterSolicitationAddress(v) => {
                Ok(DhcpOption::RouterSolicitationAddress(Ipv4Addr::from_fidl(v)))
            }
            fidl_fuchsia_net_dhcp::Option_::StaticRoute(v) => Ok(DhcpOption::StaticRoute({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::TrailerEncapsulation(v) => {
                Ok(DhcpOption::TrailerEncapsulation(v))
            }
            fidl_fuchsia_net_dhcp::Option_::ArpCacheTimeout(v) => {
                Ok(DhcpOption::ArpCacheTimeout(v))
            }
            fidl_fuchsia_net_dhcp::Option_::EthernetEncapsulation(v) => {
                Ok(DhcpOption::EthernetEncapsulation(v))
            }
            fidl_fuchsia_net_dhcp::Option_::TcpDefaultTtl(v) => {
                let ttl = NonZeroU8::new(v).ok_or_else(|| {
                    ProtocolError::InvalidOptionValue(OptionCode::TcpDefaultTtl, vec![v])
                })?;
                Ok(DhcpOption::TcpDefaultTtl(ttl))
            }
            fidl_fuchsia_net_dhcp::Option_::TcpKeepaliveInterval(v) => {
                Ok(DhcpOption::TcpKeepaliveInterval(v))
            }
            fidl_fuchsia_net_dhcp::Option_::TcpKeepaliveGarbage(v) => {
                Ok(DhcpOption::TcpKeepaliveGarbage(v))
            }
            fidl_fuchsia_net_dhcp::Option_::NetworkInformationServiceDomain(v) => {
                Ok(DhcpOption::NetworkInformationServiceDomain(v))
            }
            fidl_fuchsia_net_dhcp::Option_::NetworkInformationServers(v) => {
                Ok(DhcpOption::NetworkInformationServers({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::NetworkTimeProtocolServers(v) => {
                Ok(DhcpOption::NetworkTimeProtocolServers({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::VendorSpecificInformation(v) => {
                Ok(DhcpOption::VendorSpecificInformation({
                    let size = v.size_of_contents_in_bytes();
                    v.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipNameServer(v) => {
                Ok(DhcpOption::NetBiosOverTcpipNameServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipDatagramDistributionServer(v) => {
                Ok(DhcpOption::NetBiosOverTcpipDatagramDistributionServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipNodeType(v) => {
                Ok(DhcpOption::NetBiosOverTcpipNodeType(NodeType::try_from_fidl(v)?))
            }
            fidl_fuchsia_net_dhcp::Option_::NetbiosOverTcpipScope(v) => {
                Ok(DhcpOption::NetBiosOverTcpipScope(v))
            }
            fidl_fuchsia_net_dhcp::Option_::XWindowSystemFontServer(v) => {
                Ok(DhcpOption::XWindowSystemFontServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::XWindowSystemDisplayManager(v) => {
                Ok(DhcpOption::XWindowSystemDisplayManager({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::NetworkInformationServicePlusDomain(v) => {
                Ok(DhcpOption::NetworkInformationServicePlusDomain(v))
            }
            fidl_fuchsia_net_dhcp::Option_::NetworkInformationServicePlusServers(v) => {
                Ok(DhcpOption::NetworkInformationServicePlusServers({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::MobileIpHomeAgent(v) => {
                Ok(DhcpOption::MobileIpHomeAgent({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::SmtpServer(v) => Ok(DhcpOption::SmtpServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::Pop3Server(v) => Ok(DhcpOption::Pop3Server({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::NntpServer(v) => Ok(DhcpOption::NntpServer({
                let vec = Vec::<Ipv4Addr>::from_fidl(v);
                let size = vec.size_of_contents_in_bytes();
                vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
                    ProtocolError::InvalidBufferLength(size)
                })?
            })),
            fidl_fuchsia_net_dhcp::Option_::DefaultWwwServer(v) => {
                Ok(DhcpOption::DefaultWwwServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::DefaultFingerServer(v) => {
                Ok(DhcpOption::DefaultFingerServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::DefaultIrcServer(v) => {
                Ok(DhcpOption::DefaultIrcServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::StreettalkServer(v) => {
                Ok(DhcpOption::StreetTalkServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::StreettalkDirectoryAssistanceServer(v) => {
                Ok(DhcpOption::StreetTalkDirectoryAssistanceServer({
                    let vec = Vec::<Ipv4Addr>::from_fidl(v);
                    let vec_size = vec.size_of_contents_in_bytes();
                    vec.try_into().map_err(
                        |(size_constrained::Error::SizeConstraintViolated, _)| {
                            ProtocolError::InvalidBufferLength(vec_size)
                        },
                    )?
                }))
            }
            fidl_fuchsia_net_dhcp::Option_::OptionOverload(v) => {
                Ok(DhcpOption::OptionOverload(Overload::from_fidl(v)))
            }
            fidl_fuchsia_net_dhcp::Option_::TftpServerName(v) => Ok(DhcpOption::TftpServerName(v)),
            fidl_fuchsia_net_dhcp::Option_::BootfileName(v) => Ok(DhcpOption::BootfileName(v)),
            fidl_fuchsia_net_dhcp::Option_::MaxDhcpMessageSize(v) => {
                Ok(DhcpOption::MaxDhcpMessageSize(v))
            }
            fidl_fuchsia_net_dhcp::Option_::RenewalTimeValue(v) => {
                Ok(DhcpOption::RenewalTimeValue(v))
            }
            fidl_fuchsia_net_dhcp::Option_::RebindingTimeValue(v) => {
                Ok(DhcpOption::RebindingTimeValue(v))
            }
            fidl_fuchsia_net_dhcp::Option_Unknown!() => Err(ProtocolError::UnknownFidlOption),
        }
    }
}

/// A NetBIOS over TCP/IP Node Type.
///
/// This enum and the values of its variants corresponds to the DHCP option defined
/// in: https://tools.ietf.org/html/rfc2132#section-8.7
#[derive(Clone, Copy, Debug, Deserialize, Eq, FromPrimitive, Hash, PartialEq, Serialize)]
#[repr(u8)]
pub enum NodeType {
    BNode = 0x1,
    PNode = 0x2,
    MNode = 0x4,
    HNode = 0x8,
}

impl TryFrom<u8> for NodeType {
    type Error = ProtocolError;

    fn try_from(n: u8) -> Result<Self, Self::Error> {
        <Self as num_traits::FromPrimitive>::from_u8(n).ok_or_else(|| {
            ProtocolError::InvalidOptionValue(OptionCode::NetBiosOverTcpipNodeType, vec![n])
        })
    }
}

impl From<NodeType> for u8 {
    fn from(node_type: NodeType) -> u8 {
        node_type as u8
    }
}

#[cfg(target_os = "fuchsia")]
impl FidlCompatible<fidl_fuchsia_net_dhcp::NodeTypes> for NodeType {
    type FromError = ProtocolError;
    type IntoError = Never;

    fn try_from_fidl(fidl: fidl_fuchsia_net_dhcp::NodeTypes) -> Result<NodeType, Self::FromError> {
        match fidl {
            fidl_fuchsia_net_dhcp::NodeTypes::B_NODE => Ok(NodeType::BNode),
            fidl_fuchsia_net_dhcp::NodeTypes::P_NODE => Ok(NodeType::PNode),
            fidl_fuchsia_net_dhcp::NodeTypes::M_NODE => Ok(NodeType::MNode),
            fidl_fuchsia_net_dhcp::NodeTypes::H_NODE => Ok(NodeType::HNode),
            other => Err(ProtocolError::InvalidOptionValue(
                OptionCode::NetBiosOverTcpipNodeType,
                vec![other.bits()],
            )),
        }
    }

    fn try_into_fidl(self) -> Result<fidl_fuchsia_net_dhcp::NodeTypes, Self::IntoError> {
        match self {
            NodeType::BNode => Ok(fidl_fuchsia_net_dhcp::NodeTypes::B_NODE),
            NodeType::PNode => Ok(fidl_fuchsia_net_dhcp::NodeTypes::P_NODE),
            NodeType::MNode => Ok(fidl_fuchsia_net_dhcp::NodeTypes::M_NODE),
            NodeType::HNode => Ok(fidl_fuchsia_net_dhcp::NodeTypes::H_NODE),
        }
    }
}

/// The DHCP message fields to use for storing additional options.
///
/// A DHCP client can indicate that it wants to use the File or SName fields of
/// the DHCP header to store DHCP options. This enum and its variant values correspond
/// to the DHCP option defined in: https://tools.ietf.org/html/rfc2132#section-9.3
#[derive(Clone, Copy, Debug, Deserialize, Eq, FromPrimitive, Hash, PartialEq, Serialize)]
#[repr(u8)]
pub enum Overload {
    File = 1,
    SName = 2,
    Both = 3,
}

impl From<Overload> for u8 {
    fn from(val: Overload) -> Self {
        val as u8
    }
}

impl TryFrom<u8> for Overload {
    type Error = ProtocolError;

    fn try_from(n: u8) -> Result<Self, Self::Error> {
        <Self as num_traits::FromPrimitive>::from_u8(n)
            .ok_or_else(|| ProtocolError::InvalidOptionValue(OptionCode::OptionOverload, vec![n]))
    }
}

#[cfg(target_os = "fuchsia")]
impl FidlCompatible<fidl_fuchsia_net_dhcp::OptionOverloadValue> for Overload {
    type FromError = Never;
    type IntoError = Never;

    fn try_from_fidl(
        fidl: fidl_fuchsia_net_dhcp::OptionOverloadValue,
    ) -> Result<Self, Self::FromError> {
        match fidl {
            fidl_fuchsia_net_dhcp::OptionOverloadValue::File => Ok(Overload::File),
            fidl_fuchsia_net_dhcp::OptionOverloadValue::Sname => Ok(Overload::SName),
            fidl_fuchsia_net_dhcp::OptionOverloadValue::Both => Ok(Overload::Both),
        }
    }

    fn try_into_fidl(self) -> Result<fidl_fuchsia_net_dhcp::OptionOverloadValue, Self::IntoError> {
        match self {
            Overload::File => Ok(fidl_fuchsia_net_dhcp::OptionOverloadValue::File),
            Overload::SName => Ok(fidl_fuchsia_net_dhcp::OptionOverloadValue::Sname),
            Overload::Both => Ok(fidl_fuchsia_net_dhcp::OptionOverloadValue::Both),
        }
    }
}

/// A DHCP Message Type.
///
/// This enum corresponds to the DHCP Message Type option values
/// defined in section 9.4 of RFC 1533.
#[derive(FromPrimitive, Copy, Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)]
#[repr(u8)]
pub enum MessageType {
    DHCPDISCOVER = 1,
    DHCPOFFER = 2,
    DHCPREQUEST = 3,
    DHCPDECLINE = 4,
    DHCPACK = 5,
    DHCPNAK = 6,
    DHCPRELEASE = 7,
    DHCPINFORM = 8,
}

impl From<MessageType> for u8 {
    fn from(val: MessageType) -> Self {
        val as u8
    }
}

/// Instead of reusing the implementation of `Debug::fmt` here, a cleaner way
/// is to derive the 'Display' trait for enums using `enum-display-derive` crate
///
/// https://docs.rs/enum-display-derive/0.1.0/enum_display_derive/
///
/// Since addition of this in third_party/rust_crates needs OSRB approval
/// it should be done if there is a stronger need for more complex enums.
impl fmt::Display for MessageType {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        fmt::Debug::fmt(&self, f)
    }
}

impl TryFrom<u8> for MessageType {
    type Error = ProtocolError;

    fn try_from(n: u8) -> Result<Self, Self::Error> {
        <Self as num_traits::FromPrimitive>::from_u8(n).ok_or(ProtocolError::InvalidMessageType(n))
    }
}

/// Parses DHCP options from `buf` into `options`.
fn parse_options<T: Extend<DhcpOption>>(
    mut buf: &[u8],
    mut options: T,
) -> Result<T, ProtocolError> {
    loop {
        let (raw_opt_code, rest) = buf.split_first().ok_or({
            // From RFC 2131 Section 4.1:
            //   The last option must always be the 'end' option.
            ProtocolError::MissingOption(OptionCode::End)
        })?;
        buf = rest;
        match OptionCode::try_from(*raw_opt_code) {
            Ok(OptionCode::End) => {
                // End of options reached.
                return Ok(options);
            }
            Ok(OptionCode::Pad) => {}
            code => {
                let (&opt_len, rest) = buf.split_first().ok_or(ProtocolError::MalformedOption {
                    code: *raw_opt_code,
                    remaining: buf.len(),
                    want: 1,
                })?;
                buf = rest;
                let opt_len = usize::from(opt_len);

                // Reaching the end of the buffer means we never encountered an End code.
                if buf.len() < opt_len {
                    return Err(ProtocolError::MalformedOption {
                        code: *raw_opt_code,
                        remaining: buf.len(),
                        want: opt_len,
                    });
                };
                let (val, rest) = buf.split_at(opt_len);
                buf = rest;

                // Ignore unknown option codes, hinted at in RFC 2131 section 3.5:
                //   ... Other options representing "hints" at configuration parameters are allowed
                //   in a DHCPDISCOVER or DHCPREQUEST message.  However, additional options may be
                //   ignored by servers...
                let code = match code {
                    Ok(c) => c,
                    Err(ProtocolError::InvalidOptionCode(_)) => continue,
                    Err(e) => return Err(e),
                };

                match DhcpOption::from_raw_parts(code, val) {
                    Ok(option) => options.extend(std::iter::once(option)),
                    Err(e) => {
                        // RFC 2131 does not define how to handle invalid options.
                        // In order to match prior art, like ISC and dnsmasq, we strive to
                        // be lenient. We throw out as little as necessary and will allow a packet
                        // even if a subset of the options are invalid.
                        //
                        // For example, here is a case where ISC will use the first 4 bytes of an
                        // IPv4 Address even if the option had > 4 length.
                        // https://github.com/isc-projects/dhcp/blob/31e68e5/server/dhcp.c#L947-L959
                        debug!("error while parsing option: {}", e);
                        continue;
                    }
                }
            }
        }
    }
}

// Ensures slice is non empty. InvalidBufferLength is returned for empty slices.
fn nonempty<T>(slice: &[T]) -> Result<&[T], InvalidBufferLengthError> {
    if slice.len() == 0 {
        return Err(InvalidBufferLengthError(slice.len()));
    }
    Ok(slice)
}

fn get_byte_array<const T: usize>(bytes: &[u8]) -> Result<[u8; T], InvalidBufferLengthError> {
    bytes
        .try_into()
        .map_err(|std::array::TryFromSliceError { .. }| InvalidBufferLengthError(bytes.len()))
}

// Converts input byte slice into a single byte.
fn get_byte(bytes: &[u8]) -> Result<u8, InvalidBufferLengthError> {
    match bytes {
        [b] => Ok(*b),
        bytes => Err(InvalidBufferLengthError(bytes.len())),
    }
}

// Converts input byte slice into a nonempty utf8 string.
fn bytes_to_nonempty_str(bytes: &[u8]) -> Result<String, ProtocolError> {
    // Spec states that strings should not be null terminated, yet receivers
    // should be prepared to trim trailing nulls.
    // See https://datatracker.ietf.org/doc/html/rfc2132#section-2
    std::str::from_utf8(nonempty(bytes)?.into())
        .map_err(|e| ProtocolError::Utf8(e.valid_up_to()))
        .map(|string| string.trim_end_matches(ASCII_NULL).to_owned())
}

// Converts input byte slice into an Ipv4Addr.
fn bytes_to_addr(bytes: &[u8]) -> Result<Ipv4Addr, InvalidBufferLengthError> {
    Ok(Ipv4Addr::from(get_byte_array::<4>(bytes)?))
}

// Converts an input byte slice into a list of Ipv4Addr.
fn bytes_to_addrs<const LOWER_BOUND: usize>(
    bytes: &[u8],
) -> Result<
    AtLeast<LOWER_BOUND, AtMostBytes<{ size_constrained::U8_MAX_AS_USIZE }, Vec<Ipv4Addr>>>,
    InvalidBufferLengthError,
> {
    let vec = bytes
        .chunks(IPV4_ADDR_LEN)
        .map(bytes_to_addr)
        .collect::<Result<Vec<Ipv4Addr>, InvalidBufferLengthError>>()
        .map_err(|InvalidBufferLengthError(_)| InvalidBufferLengthError(bytes.len()))?;
    vec.try_into().map_err(|(size_constrained::Error::SizeConstraintViolated, _)| {
        InvalidBufferLengthError(bytes.len())
    })
}

#[derive(Debug, Error, PartialEq)]
enum BooleanConversionError {
    #[error("invalid buffer length: {}", _0)]
    InvalidBufferLength(usize),
    #[error("invalid value: {}", _0)]
    InvalidValue(u8),
}

impl BooleanConversionError {
    fn to_protocol(&self, code: OptionCode) -> ProtocolError {
        match self {
            Self::InvalidBufferLength(len) => ProtocolError::InvalidBufferLength(*len),
            Self::InvalidValue(val) => ProtocolError::InvalidOptionValue(code, vec![*val]),
        }
    }
}

// Returns a bool from a nonempty byte slice.
fn bytes_to_bool(bytes: &[u8]) -> Result<bool, BooleanConversionError> {
    let byte = get_byte(bytes)?;
    match byte {
        0 | 1 => Ok(byte == 1),
        b => Err(BooleanConversionError::InvalidValue(b)),
    }
}

// Returns an Ipv4Addr when given a byte buffer in network order whose len >= start + 4.
pub fn ip_addr_from_buf_at(buf: &[u8], start: usize) -> Result<Ipv4Addr, ProtocolError> {
    let buf = buf.get(start..start + 4).ok_or(ProtocolError::InvalidBufferLength(buf.len()))?;
    let buf: [u8; 4] = buf.try_into().map_err(|std::array::TryFromSliceError { .. }| {
        ProtocolError::InvalidBufferLength(buf.len())
    })?;
    Ok(buf.into())
}

const NULL_TERMINATOR: u8 = 0;

fn buf_to_msg_string(buf: &[u8]) -> BString {
    // As per RFC 2131, Section 2: the `sname` and `file` fields are each a
    // "null terminated string". This leaves it ambiguous whether the null
    // terminator is expected to be present in the buffer. We implement relaxed
    // parsing, allowing it to be absent.
    let null_terminator_position =
        buf.iter().position(|&b| b == NULL_TERMINATOR).unwrap_or(buf.len());
    BString::from(&buf[..null_terminator_position])
}
fn trunc_string_to_n_and_push(s: &BString, n: usize, buffer: &mut Vec<u8>) {
    let s: &[u8] = s.as_ref();
    // As per RFC 2131, Section 2: the `sname` and `file` fields are each a
    // "null terminated string". This leaves it ambiguous whether the null
    // terminator is expected to be present in the buffer. We implement strict
    // serialization, requiring it be present.
    if s.len() >= n {
        let (truncated, _dropped) = s.split_at(n - 1);
        buffer.extend(truncated);
        buffer.push(NULL_TERMINATOR);
        return;
    }
    buffer.extend(s);
    let unused_bytes = n - s.len();
    let old_len = buffer.len();
    buffer.resize(old_len + unused_bytes, NULL_TERMINATOR);
}

#[cfg(test)]
mod tests {
    use super::identifier::ClientIdentifier;
    use super::*;
    use net_declare::net::prefix_length_v4;
    use net_declare::std::ip_v4;
    use std::str::FromStr;
    use test_case::test_case;

    const DEFAULT_SUBNET_MASK: PrefixLength<Ipv4> = prefix_length_v4!(24);

    fn new_test_msg() -> Message {
        Message {
            op: OpCode::BOOTREQUEST,
            xid: 42,
            secs: 1024,
            bdcast_flag: false,
            ciaddr: Ipv4Addr::UNSPECIFIED,
            yiaddr: ip_v4!("192.168.1.1"),
            siaddr: Ipv4Addr::UNSPECIFIED,
            giaddr: Ipv4Addr::UNSPECIFIED,
            chaddr: MacAddr::new([0; 6]),
            sname: BString::from("relay.example.com"),
            file: BString::from("boot.img"),
            options: Vec::new(),
        }
    }

    #[test]
    fn serialize_returns_correct_bytes() {
        let mut msg = new_test_msg();
        msg.options.push(DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK));

        let bytes = msg.serialize();

        assert_eq!(bytes.len(), 247);
        assert_eq!(bytes[0], 1u8);
        assert_eq!(bytes[1], 1u8);
        assert_eq!(bytes[2], 6u8);
        assert_eq!(bytes[3], 0u8);
        assert_eq!(bytes[7], 42u8);
        assert_eq!(bytes[8], 4u8);
        assert_eq!(bytes[16], 192u8);
        assert_eq!(bytes[17], 168u8);
        assert_eq!(bytes[18], 1u8);
        assert_eq!(bytes[19], 1u8);
        assert_eq!(bytes[44], 'r' as u8);
        assert_eq!(bytes[60], 'm' as u8);
        assert_eq!(bytes[61], 0u8);
        assert_eq!(bytes[108], 'b' as u8);
        assert_eq!(bytes[115], 'g' as u8);
        assert_eq!(bytes[116], 0u8);
        assert_eq!(bytes[OPTIONS_START_IDX..OPTIONS_START_IDX + MAGIC_COOKIE.len()], MAGIC_COOKIE);
        assert_eq!(bytes[bytes.len() - 1], 255u8);
    }

    #[test]
    fn message_from_buffer_returns_correct_message() {
        let mut buf = Vec::new();
        buf.push(1u8);
        buf.push(1u8);
        buf.push(6u8);
        buf.push(0u8);
        buf.extend_from_slice(b"\x00\x00\x00\x2A");
        buf.extend_from_slice(b"\x04\x00");
        buf.extend_from_slice(b"\x00\x00");
        buf.extend_from_slice(b"\x00\x00\x00\x00");
        buf.extend_from_slice(b"\xC0\xA8\x01\x01");
        buf.extend_from_slice(b"\x00\x00\x00\x00");
        buf.extend_from_slice(b"\x00\x00\x00\x00");
        buf.extend_from_slice(b"\x00\x00\x00\x00\x00\x00");
        buf.extend_from_slice(b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00");
        buf.extend_from_slice(b"relay.example.com");
        let mut old_len = buf.len();
        let mut unused_bytes = SNAME_LEN - b"relay.example.com".len();
        buf.resize(old_len + unused_bytes, 0u8);
        buf.extend_from_slice(b"boot.img");
        old_len = buf.len();
        unused_bytes = FILE_LEN - b"boot.img".len();
        buf.resize(old_len + unused_bytes, 0u8);
        buf.extend_from_slice(&MAGIC_COOKIE);
        buf.extend_from_slice(b"\x01\x04");
        buf.extend_from_slice(&DEFAULT_SUBNET_MASK.get_mask().ipv4_bytes()[..]);
        buf.extend_from_slice(b"\x00");
        buf.extend_from_slice(b"\x00");
        buf.extend_from_slice(b"\x36\x04");
        let server_id = ip_v4!("1.2.3.4");
        buf.extend_from_slice(&server_id.octets()[..]);
        buf.extend_from_slice(b"\xFF");

        assert_eq!(
            Message::from_buffer(&buf),
            Ok(Message {
                op: OpCode::BOOTREQUEST,
                xid: 42,
                secs: 1024,
                bdcast_flag: false,
                ciaddr: Ipv4Addr::UNSPECIFIED,
                yiaddr: ip_v4!("192.168.1.1"),
                siaddr: Ipv4Addr::UNSPECIFIED,
                giaddr: Ipv4Addr::UNSPECIFIED,
                chaddr: MacAddr::new([0; 6]),
                sname: BString::from("relay.example.com"),
                file: BString::from("boot.img"),
                options: vec![
                    DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK),
                    DhcpOption::ServerIdentifier(server_id),
                ],
            })
        );
    }

    #[test]
    fn serialize_then_deserialize_with_single_option_is_equal_to_starting_value() {
        let msg = || {
            let mut msg = new_test_msg();
            msg.options.push(DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK));
            msg
        };

        assert_eq!(Message::from_buffer(&msg().serialize()), Ok(msg()));
    }

    #[test]
    fn serialize_then_deserialize_with_no_options_is_equal_to_starting_value() {
        let msg = new_test_msg();

        assert_eq!(Message::from_buffer(&msg.serialize()), Ok(new_test_msg()));
    }

    #[test]
    fn serialize_then_deserialize_with_many_options_is_equal_to_starting_value() {
        let msg = || {
            let mut msg = new_test_msg();
            msg.options.push(DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK));
            msg.options.push(DhcpOption::NameServer([ip_v4!("1.2.3.4")].into()));
            msg.options.push(DhcpOption::DhcpMessageType(MessageType::DHCPDISCOVER));
            msg.options.push(DhcpOption::ParameterRequestList([OptionCode::SubnetMask].into()));
            msg.options.push(DhcpOption::PathMtuPlateauTable([1480u16].into()));
            msg
        };

        assert_eq!(Message::from_buffer(&msg().serialize()), Ok(msg()));
    }

    #[test]
    fn strips_null_from_option_strings() {
        let ascii_str = String::from("Hello World");
        let null_terminated_str = format!("{}{}", ascii_str, ASCII_NULL);
        let msg = Message {
            options: vec![DhcpOption::MeritDumpFile(null_terminated_str)],
            ..new_test_msg()
        };
        let Message { options: parsed_options, .. } = Message::from_buffer(&msg.serialize())
            .expect("Parsing serialized message should succeed.");
        assert_eq!(parsed_options, vec![DhcpOption::MeritDumpFile(ascii_str)]);
    }

    #[test]
    fn message_from_too_short_buffer_returns_error() {
        let buf = vec![0u8, 0u8, 0u8];

        assert_eq!(
            Message::from_buffer(&buf),
            Err(ProtocolError::InvalidBufferLength(buf.len()).into())
        );
    }

    #[test]
    fn serialize_with_valid_option_returns_correct_bytes() {
        let opt = DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK);
        let mut bytes = Vec::with_capacity(6);
        opt.serialize_to(&mut bytes);
        assert_eq!(bytes.len(), 6);
        assert_eq!(bytes[0], 1);
        assert_eq!(bytes[1], 4);
        assert_eq!(bytes[2], 255);
        assert_eq!(bytes[3], 255);
        assert_eq!(bytes[4], 255);
        assert_eq!(bytes[5], 0);
    }

    #[test]
    fn serialize_with_fixed_len_option_returns_correct_bytes() {
        let opt = DhcpOption::End();
        let mut bytes = Vec::with_capacity(1);
        opt.serialize_to(&mut bytes);
        assert_eq!(bytes.len(), 1);
        assert_eq!(bytes[0], 255);
    }

    #[test]
    fn option_from_valid_buffer_has_correct_value() {
        let buf = vec![1, 4, 255, 255, 255, 0, 255];
        assert_eq!(
            parse_options(&buf[..], Vec::new()),
            Ok(vec![DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK)])
        );
    }

    #[test]
    fn option_from_valid_buffer_with_fixed_length_returns_empty_options() {
        let buf = vec![255];
        assert_eq!(parse_options(&buf[..], Vec::new()), Ok(Vec::new()));
    }

    #[test]
    fn option_from_valid_buffer_ignores_unknown_opcodes() {
        let buf = vec![254, 2, 1, 2, 255];
        assert_eq!(parse_options(&buf[..], Vec::new()), Ok(Vec::new()));
    }

    #[test]
    fn option_stops_at_end_of_options() {
        let buf = vec![26, 2, 4, 0, 255, 26, 2, 4, 0];
        assert_eq!(parse_options(&buf[..], Vec::new()), Ok(vec![DhcpOption::InterfaceMtu(1024)]));
    }

    #[test]
    fn option_from_buffer_with_invalid_length_returns_err() {
        let buf = vec![1, 6, 255, 255, 255, 0];
        assert_eq!(
            parse_options(&buf[..], Vec::new()),
            Err(ProtocolError::MalformedOption { code: 1, remaining: 4, want: 6 })
        );
    }

    #[test]
    fn option_from_buffer_missing_length_returns_err() {
        let buf = vec![1];
        assert_eq!(
            parse_options(&buf[..], Vec::new()),
            Err(ProtocolError::MalformedOption { code: 1, remaining: 0, want: 1 })
        );
    }

    #[test]
    fn option_from_buffer_missing_end_option_returns_err() {
        assert_eq!(
            parse_options(&[], Vec::new()),
            Err(ProtocolError::MissingOption(OptionCode::End))
        );
    }

    #[test]
    fn get_dhcp_type_with_dhcp_type_option_returns_value() {
        let mut msg = new_test_msg();
        msg.options.push(DhcpOption::DhcpMessageType(MessageType::DHCPDISCOVER));

        assert_eq!(msg.get_dhcp_type(), Ok(MessageType::DHCPDISCOVER));
    }

    #[test]
    fn get_dhcp_type_without_dhcp_type_option_returns_err() {
        let msg = new_test_msg();

        assert_eq!(
            msg.get_dhcp_type(),
            Err(ProtocolError::MissingOption(OptionCode::DhcpMessageType).into())
        );
    }

    #[test]
    fn buf_into_options_with_invalid_option_parses_other_valid_options() {
        let msg = || {
            let mut msg = new_test_msg();
            msg.options.push(DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK));
            msg.options.push(DhcpOption::Router([ip_v4!("192.168.1.1")].into()));
            msg.options.push(DhcpOption::DhcpMessageType(MessageType::DHCPDISCOVER));
            msg
        };

        let mut buf = msg().serialize();
        // introduce invalid option code in first option
        buf[OPTIONS_START_IDX + 4] = 99;

        // Expect that everything but the invalid option deserializes.
        let mut expected_msg = msg();
        assert_eq!(expected_msg.options.remove(0), DhcpOption::SubnetMask(DEFAULT_SUBNET_MASK));
        assert_eq!(Message::from_buffer(&buf), Ok(expected_msg));
    }

    #[test_case(OptionCode::HostName, 0; "Min length 1")]
    #[test_case(OptionCode::ClientIdentifier, 1; "Min length 2_1")]
    #[test_case(OptionCode::PathMtuPlateauTable, 1; "Min length 2_2")]
    #[test_case(OptionCode::Router, 0; "Min length 4")]
    #[test_case(OptionCode::PolicyFilter, 4; "Min length 8_1")]
    #[test_case(OptionCode::StaticRoute, 4; "Min length 8_2")]
    fn parse_options_with_invalid_min_lengths(code: OptionCode, len: usize) {
        let option = DhcpOption::from_raw_parts(code, &vec![0; len]);
        assert_eq!(Err(ProtocolError::InvalidBufferLength(len)), option)
    }

    #[test_case(OptionCode::IpForwarding, 0; "Length = 1")]
    #[test_case(OptionCode::BootfileName, 0; "Length = 2")]
    #[test_case(OptionCode::TimeOffset, 0; "Length = 4")]
    fn parse_options_with_invalid_static_length(code: OptionCode, len: usize) {
        let option = DhcpOption::from_raw_parts(code, &vec![0; len]);
        assert_eq!(Err(ProtocolError::InvalidBufferLength(len)), option)
    }

    #[test_case(OptionCode::PathMtuPlateauTable, 3; "Min length 2, multiple of 2")]
    #[test_case(OptionCode::MobileIpHomeAgent, 5; "Min length 0, multiple of 4")]
    #[test_case(OptionCode::PolicyFilter, 4; "PolicyFilter_4: Min length 8, multiple of 8")]
    #[test_case(OptionCode::PolicyFilter, 12; "PolicyFilter_12: Min length 8, multiple of 8 - 2")]
    #[test_case(OptionCode::StaticRoute, 4; "StaticRoute_4: Min length 8, multiple of 8 - 1")]
    #[test_case(OptionCode::StaticRoute, 12; "StaticRoute_12: Min length 8, multiple of 8 - 2")]
    fn parse_options_with_invalid_length_multiples(code: OptionCode, len: usize) {
        let option = DhcpOption::from_raw_parts(code, &vec![0; len]);
        assert_eq!(Err(ProtocolError::InvalidBufferLength(len)), option)
    }

    #[test_case(OptionCode::IpForwarding)]
    #[test_case(OptionCode::NonLocalSourceRouting)]
    #[test_case(OptionCode::AllSubnetsLocal)]
    #[test_case(OptionCode::PerformMaskDiscovery)]
    #[test_case(OptionCode::MaskSupplier)]
    #[test_case(OptionCode::PerformRouterDiscovery)]
    #[test_case(OptionCode::TrailerEncapsulation)]
    #[test_case(OptionCode::EthernetEncapsulation)]
    #[test_case(OptionCode::TcpKeepaliveGarbage)]
    fn parse_options_with_invalid_flag_value(code: OptionCode) {
        let val = vec![2];
        let option = DhcpOption::from_raw_parts(code, &val);
        assert_eq!(Err(ProtocolError::InvalidOptionValue(code, val)), option)
    }

    #[test_case(0)]
    #[test_case(4)]
    fn parse_options_with_invalid_overload_value(overload: u8) {
        let code = OptionCode::OptionOverload;
        let val = vec![overload];
        let option = DhcpOption::from_raw_parts(code, &val);

        // Valid values are 1, 2, 3.
        assert_eq!(Err(ProtocolError::InvalidOptionValue(code, val)), option);
    }

    #[test]
    fn parse_options_with_invalid_netbios_node_value() {
        // Valid values are 1, 2, 4, 8
        let code = OptionCode::NetBiosOverTcpipNodeType;
        let val = vec![3];
        let option = DhcpOption::from_raw_parts(code, &val);
        assert_eq!(Err(ProtocolError::InvalidOptionValue(code, val)), option);
    }

    #[test_case(OptionCode::DefaultIpTtl)]
    #[test_case(OptionCode::TcpDefaultTtl)]
    fn parse_options_with_invalid_ttl_value(code: OptionCode) {
        let val = vec![0];
        let option = DhcpOption::from_raw_parts(code, &val);
        assert_eq!(Err(ProtocolError::InvalidOptionValue(code, val)), option);
    }

    #[test_case(OptionCode::MaxDatagramReassemblySize, MIN_MESSAGE_SIZE)]
    #[test_case(OptionCode::MaxDhcpMessageSize, MIN_MESSAGE_SIZE)]
    #[test_case(OptionCode::InterfaceMtu, MIN_MTU_VAL)]
    fn parse_options_with_too_low_value(code: OptionCode, min_size: u16) {
        let val = (min_size - 1).to_be_bytes().to_vec();
        let option = DhcpOption::from_raw_parts(code, &val);
        assert_eq!(Err(ProtocolError::InvalidOptionValue(code, val)), option);
    }

    #[test]
    fn rejects_invalid_subnet_mask() {
        let mask = vec![255, 254, 255, 0];

        assert_eq!(
            DhcpOption::from_raw_parts(OptionCode::SubnetMask, &mask),
            Err(ProtocolError::InvalidOptionValue(OptionCode::SubnetMask, mask))
        )
    }

    #[test]
    fn parameter_request_list_with_known_and_unknown_options_returns_known_options() {
        assert_eq!(
            DhcpOption::from_raw_parts(
                OptionCode::ParameterRequestList,
                &[
                    121, /* unrecognized */
                    1, 3, 6, 15, 31, 33, 249, /* unrecognized */
                    43, 44, 46, 47, 119, /* unrecognized */
                    252, /* unrecognized */
                ]
            ),
            Ok(DhcpOption::ParameterRequestList(
                [
                    OptionCode::SubnetMask,
                    OptionCode::Router,
                    OptionCode::DomainNameServer,
                    OptionCode::DomainName,
                    OptionCode::PerformRouterDiscovery,
                    OptionCode::StaticRoute,
                    OptionCode::VendorSpecificInformation,
                    OptionCode::NetBiosOverTcpipNameServer,
                    OptionCode::NetBiosOverTcpipNodeType,
                    OptionCode::NetBiosOverTcpipScope,
                ]
                .into()
            ))
        );
    }

    fn random_ipv4_generator() -> Ipv4Addr {
        let (octet1, octet2, octet3, octet4) = rand::random();
        Ipv4Addr::new(octet1, octet2, octet3, octet4)
    }

    fn test_option_overload(overload: Overload) {
        let mut msg = Message {
            op: OpCode::BOOTREQUEST,
            xid: 0,
            secs: 0,
            bdcast_flag: false,
            ciaddr: Ipv4Addr::UNSPECIFIED,
            yiaddr: Ipv4Addr::UNSPECIFIED,
            siaddr: Ipv4Addr::UNSPECIFIED,
            giaddr: Ipv4Addr::UNSPECIFIED,
            chaddr: MacAddr::new([0; 6]),
            sname: BString::default(),
            file: BString::default(),
            options: vec![DhcpOption::OptionOverload(overload)],
        }
        .serialize();
        let ip = random_ipv4_generator();
        let first_extra_opt = {
            let mut acc = Vec::new();
            DhcpOption::RequestedIpAddress(ip).serialize_to(&mut acc);
            acc
        };
        let last_extra_opt = {
            let mut acc = Vec::new();
            DhcpOption::End().serialize_to(&mut acc);
            acc
        };
        let (extra_opts, start_idx) = match overload {
            Overload::SName => ([&first_extra_opt[..], &last_extra_opt[..]].concat(), SNAME_IDX),
            Overload::File => ([&first_extra_opt[..], &last_extra_opt[..]].concat(), FILE_IDX),
            Overload::Both => {
                // Insert enough padding bytes such that extra_opts will straddle both file and
                // sname fields.
                ([&first_extra_opt[..], &[0u8; SNAME_LEN], &last_extra_opt[..]].concat(), SNAME_IDX)
            }
        };
        let _: std::vec::Splice<'_, _> =
            msg.splice(start_idx..start_idx + extra_opts.len(), extra_opts);
        assert_eq!(
            Message::from_buffer(&msg),
            Ok(Message {
                op: OpCode::BOOTREQUEST,
                xid: 0,
                secs: 0,
                bdcast_flag: false,
                ciaddr: Ipv4Addr::UNSPECIFIED,
                yiaddr: Ipv4Addr::UNSPECIFIED,
                siaddr: Ipv4Addr::UNSPECIFIED,
                giaddr: Ipv4Addr::UNSPECIFIED,
                chaddr: MacAddr::new([0; 6]),
                sname: BString::default(),
                file: BString::default(),
                options: vec![
                    DhcpOption::OptionOverload(overload),
                    DhcpOption::RequestedIpAddress(ip)
                ],
            })
        );
    }

    #[test]
    fn message_with_option_overload_parses_extra_options() {
        test_option_overload(Overload::SName);
        test_option_overload(Overload::File);
        test_option_overload(Overload::Both);
    }

    #[test]
    fn client_identifier_from_str() {
        assert_matches::assert_matches!(
            ClientIdentifier::from_str("id:1234567890abcd"),
            Ok(ClientIdentifier { .. })
        );
        assert_matches::assert_matches!(
            ClientIdentifier::from_str("chaddr:1234567890ab"),
            Ok(ClientIdentifier { .. })
        );
        // incorrect type prefix
        assert_matches::assert_matches!(ClientIdentifier::from_str("option:1234567890"), Err(..));
        // extra field
        assert_matches::assert_matches!(ClientIdentifier::from_str("id:1234567890:extra"), Err(..));
        // no type prefix
        assert_matches::assert_matches!(ClientIdentifier::from_str("1234567890"), Err(..));
        // no delimiter
        assert_matches::assert_matches!(ClientIdentifier::from_str("id1234567890"), Err(..));
        // incorrect delimiter
        assert_matches::assert_matches!(ClientIdentifier::from_str("id-1234567890"), Err(..));
        // invalid hex digits
        assert_matches::assert_matches!(
            ClientIdentifier::from_str("id:1234567890abcdefg"),
            Err(..)
        );
        // odd number of hex digits
        assert_matches::assert_matches!(ClientIdentifier::from_str("id:123456789"), Err(..));
        // insufficient digits for chaddr
        assert_matches::assert_matches!(ClientIdentifier::from_str("chaddr:1234567890"), Err(..));
    }

    #[test]
    fn buf_to_msg_string_truncates_at_null_terminator() {
        let buf = [b'a', b'b', b'c', 0, b'd', b'e', b'f'];
        assert_eq!(buf_to_msg_string(&buf), BString::from("abc"));
    }

    #[test]
    fn trunc_string_to_n_and_push_adds_null_terminator() {
        let string = BString::from("abc");

        // There is enough room for the entire string.
        let mut buf = Vec::new();
        trunc_string_to_n_and_push(&string, 4, &mut buf);
        assert_eq!(&buf[..], &[b'a', b'b', b'c', 0,]);

        // The string has to be truncated to fit.
        let mut buf = Vec::new();
        trunc_string_to_n_and_push(&string, 3, &mut buf);
        assert_eq!(&buf[..], &[b'a', b'b', 0]);
    }
}