1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
// Copyright 2022 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

use {
    anyhow::Error,
    argh::FromArgs,
    async_utils::stream::{StreamItem, WithEpitaph},
    fidl::endpoints::{create_proxy, ControlHandle, RequestStream},
    fidl_fuchsia_component_runner as fcrunner, fidl_fuchsia_sys2 as fsys, fuchsia_async as fasync,
    fuchsia_component::{
        client::{connect_to_protocol, connect_to_protocol_at_dir_svc},
        server::ServiceFs,
    },
    fuchsia_component_test::{ScopedInstance, ScopedInstanceFactory},
    futures::prelude::*,
    tracing::{info, warn},
};

const RUNNER_COLLECTION: &str = "runners";

#[derive(FromArgs)]
/// Serve a test runner using a nested test runner that is restarted for each test.
struct Args {
    #[argh(positional)]
    /// the nested test runner to launch.
    nested_runner_url: String,
}

#[fuchsia::main(logging_tags=["dart_wrapper_runner"])]
async fn main() -> Result<(), Error> {
    info!("started");
    let Args { nested_runner_url } = argh::from_env();

    let mut fs = ServiceFs::new_local();
    fs.dir("svc").add_fidl_service(move |stream| {
        info!("Got stream");
        let nested_runner_url_clone = nested_runner_url.clone();
        fasync::Task::local(async move {
            start_runner(stream, &nested_runner_url_clone)
                .await
                .unwrap_or_else(|e| warn!(?e, "failed to run runner."));
        })
        .detach();
    });
    fs.take_and_serve_directory_handle()?;
    fs.collect::<()>().await;
    Ok(())
}

async fn start_runner(
    request_stream: fcrunner::ComponentRunnerRequestStream,
    runner_url: &str,
) -> Result<(), Error> {
    request_stream
        .map_err(Error::from)
        .try_for_each_concurrent(
            None,
            |fcrunner::ComponentRunnerRequest::Start { start_info, controller, .. }| async move {
                info!("Starting nested runner");
                let mut nested =
                    ScopedInstanceFactory::new(RUNNER_COLLECTION).new_instance(runner_url).await?;
                if let Err(e) =
                    run_component_controller(&nested, start_info, controller.into_stream()?).await
                {
                    warn!("Failed to run component: {:?}", e);
                }
                info!("Tearing down nested runner");
                let destroy_awaiter = nested.take_destroy_waiter();
                drop(nested);
                if let Err(e) = destroy_awaiter.await {
                    warn!("Failed to destroy nested runner: {:?}", e);
                }
                Ok(())
            },
        )
        .await
}

/// Proxy a ComponentController stream to a nested runner.
/// Returns true iff Stop or Kill was called before the proxy terminated.
async fn run_component_controller(
    nested_runner: &ScopedInstance,
    start_info: fcrunner::ComponentStartInfo,
    request_stream: fcrunner::ComponentControllerRequestStream,
) -> Result<(), Error> {
    let is_test = component_is_test(&start_info);

    let relative_moniker = format!("./{}:{}", RUNNER_COLLECTION, nested_runner.child_name());

    let controller = connect_to_protocol::<fsys::LifecycleControllerMarker>()?;
    controller.start(&relative_moniker).await?.expect("nested runer could not be started");

    let realm_query = connect_to_protocol::<fsys::RealmQueryMarker>()?;
    let resolved_dirs = realm_query
        .get_instance_directories(&relative_moniker)
        .await?
        .unwrap()
        .expect("nested runner was not resolved");
    let execution_dirs = resolved_dirs.execution_dirs.expect("nested runner was not started");
    let out_dir = execution_dirs.out_dir.expect("nested runner does not have out dir");
    let out_dir = out_dir.into_proxy().unwrap();

    let component_runner =
        connect_to_protocol_at_dir_svc::<fcrunner::ComponentRunnerMarker>(&out_dir)?;
    let (nested_controller, server_end) = create_proxy::<fcrunner::ComponentControllerMarker>()?;
    component_runner.start(start_info, server_end)?;
    proxy_component_controller(nested_controller, request_stream, is_test).await
}

async fn proxy_component_controller(
    nested_controller: fcrunner::ComponentControllerProxy,
    request_stream: fcrunner::ComponentControllerRequestStream,
    is_test: bool,
) -> Result<(), Error> {
    let nested_controller_events = nested_controller.take_event_stream();
    let request_stream_control = request_stream.control_handle();

    enum ProxyEvent<T, U> {
        ClientRequest(T),
        ServerEvent(U),
    }

    let mut combined_stream = futures::stream::select(
        request_stream.with_epitaph(()).map(ProxyEvent::ClientRequest),
        nested_controller_events.map(ProxyEvent::ServerEvent),
    );

    let mut stop_or_kill_called = false;
    let mut nested_controller_epitaph = None;

    while let Some(event) = combined_stream.next().await {
        match event {
            ProxyEvent::ClientRequest(StreamItem::Epitaph(()))
            | ProxyEvent::ClientRequest(StreamItem::Item(Err(_))) => {
                // channel to client is broken - no need to do any more work.
                break;
            }
            ProxyEvent::ClientRequest(StreamItem::Item(Ok(request))) => match request {
                fcrunner::ComponentControllerRequest::Stop { control_handle: _ } => {
                    if let Err(e) = nested_controller.stop() {
                        warn!("failed forwarding Stop() to dart runner: {e}")
                    }
                    stop_or_kill_called = true;
                }
                fcrunner::ComponentControllerRequest::Kill { control_handle: _ } => {
                    if let Err(e) = nested_controller.kill() {
                        warn!("failed forwarding Kill() to dart runner: {e}")
                    }
                    stop_or_kill_called = true;
                }
            },

            ProxyEvent::ServerEvent(Ok(
                fcrunner::ComponentControllerEvent::OnPublishDiagnostics { payload },
            )) => {
                request_stream_control.send_on_publish_diagnostics(payload).unwrap_or_else(|e| {
                    warn!("failed forwarding send_on_publish_diagnostics: {e}")
                });
            }
            ProxyEvent::ServerEvent(Err(fidl::Error::ClientChannelClosed { status, .. })) => {
                nested_controller_epitaph = Some(status);
            }
            ProxyEvent::ServerEvent(Err(e)) => {
                warn!("failed to get event: {e:?}");
            }
        }
        // The real Dart runner appears to close the controller with an epitaph
        // before fuchsia.test.Suite completes running. Because of this, in the
        // case of tests, killing the runner immediately after the proxy terminates
        // can kill fuchsia.test.Suite, preventing test_manager from retrieving
        // test results.
        // To handle this case, for tests only we ignore the signal and wait for
        // stop or kill to be called instead. Note that this could cause timeouts
        // during destruction if a test crashes, but this will likely be reported
        // over fuchsia.test.Suite.
        if is_test && !stop_or_kill_called {
            continue;
        }
        if let Some(status) = nested_controller_epitaph {
            request_stream_control.shutdown_with_epitaph(status);
        }
    }
    Ok(())
}

fn component_is_test(start_info: &fcrunner::ComponentStartInfo) -> bool {
    // The dart runner identifies tests using an --is_test=true argument passed in via the program
    // definition.
    const TEST_ARG: &str = "--is_test=true";
    let args = runner::get_program_args(start_info);
    args.iter().any(|arg| arg == TEST_ARG)
}

#[cfg(test)]
mod test {
    use {
        super::*, assert_matches::assert_matches, fidl::endpoints::create_proxy_and_stream,
        futures::task::Poll,
    };

    #[fuchsia::test]
    async fn closing_client_closes_server() {
        let (client_proxy, client_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");
        let (server_proxy, mut server_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");

        let task = fasync::Task::spawn(proxy_component_controller(
            server_proxy,
            client_request_stream,
            false,
        ));

        drop(client_proxy);
        assert!(server_request_stream.next().await.is_none());
        task.await.expect("proxy future failed");
    }

    #[fuchsia::test]
    async fn closing_server_closes_client_if_not_test() {
        let (client_proxy, client_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");
        let (server_proxy, mut server_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");

        let task = fasync::Task::spawn(proxy_component_controller(
            server_proxy,
            client_request_stream,
            false,
        ));

        server_request_stream.control_handle().shutdown_with_epitaph(fidl::Status::OK);
        assert!(server_request_stream.next().await.is_none());

        assert_matches!(
            client_proxy.take_event_stream().next().await.unwrap(),
            Err(fidl::Error::ClientChannelClosed { status: fidl::Status::OK, .. })
        );
        task.await.expect("proxy future failed");
    }

    #[fuchsia::test]
    fn closing_server_does_not_close_client_until_stop_called_if_test() {
        let mut executor = fasync::TestExecutor::new();

        let (client_proxy, client_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");
        let (server_proxy, mut server_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");

        let mut proxy_fut =
            proxy_component_controller(server_proxy, client_request_stream, true).boxed();

        server_request_stream.control_handle().shutdown_with_epitaph(fidl::Status::OK);
        assert_matches!(
            executor.run_until_stalled(&mut server_request_stream.next()),
            Poll::Ready(None)
        );
        drop(server_request_stream);

        assert_matches!(executor.run_until_stalled(&mut proxy_fut), Poll::Pending);

        let mut event_stream = client_proxy.take_event_stream();
        assert_matches!(executor.run_until_stalled(&mut event_stream.next()), Poll::Pending);

        // After calling stop or kill, the client channel should close.
        client_proxy.stop().expect("stop should succeed");
        assert_matches!(executor.run_until_stalled(&mut proxy_fut), Poll::Ready(Ok(())));
        assert_matches!(
            executor.run_until_stalled(&mut event_stream.next()),
            Poll::Ready(Some(Err(fidl::Error::ClientChannelClosed {
                status: fidl::Status::OK,
                ..
            })))
        );
    }

    #[fuchsia::test]
    fn closing_server_closes_client_if_stop_already_called_if_test() {
        let mut executor = fasync::TestExecutor::new();

        let (client_proxy, client_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");
        let (server_proxy, mut server_request_stream) =
            create_proxy_and_stream::<fcrunner::ComponentControllerMarker>()
                .expect("create stream");

        let mut proxy_fut =
            proxy_component_controller(server_proxy, client_request_stream, true).boxed();

        client_proxy.stop().expect("stop should succeed");

        assert_matches!(executor.run_until_stalled(&mut proxy_fut), Poll::Pending);

        let mut event_stream = client_proxy.take_event_stream();
        assert_matches!(executor.run_until_stalled(&mut event_stream.next()), Poll::Pending);

        server_request_stream.control_handle().shutdown_with_epitaph(fidl::Status::OK);
        assert_matches!(
            executor.run_until_stalled(&mut server_request_stream.next()),
            Poll::Ready(None)
        );
        drop(server_request_stream);

        assert_matches!(executor.run_until_stalled(&mut proxy_fut), Poll::Ready(Ok(())));
        assert_matches!(
            executor.run_until_stalled(&mut event_stream.next()),
            Poll::Ready(Some(Err(fidl::Error::ClientChannelClosed {
                status: fidl::Status::OK,
                ..
            })))
        );
    }
}